From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10995 invoked by alias); 25 Aug 2013 01:50:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10540 invoked by uid 89); 25 Aug 2013 01:50:05 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.2 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 25 Aug 2013 01:50:04 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VDPSq-0000SC-W6 from Yao_Qi@mentor.com ; Sat, 24 Aug 2013 18:50:01 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 24 Aug 2013 18:50:01 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Sat, 24 Aug 2013 18:49:59 -0700 Message-ID: <52196299.5050004@codesourcery.com> Date: Sun, 25 Aug 2013 01:50:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH 06/13] fix up gdb.mi References: <1377290210-483-1-git-send-email-tromey@redhat.com> <1377290210-483-7-git-send-email-tromey@redhat.com> In-Reply-To: <1377290210-483-7-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-08/txt/msg00721.txt.bz2 On 08/24/2013 04:36 AM, Tom Tromey wrote: > # No notification is emitted for 'maint set' commands. > foreach boolean_opt { "on" "off" } { > - mi_gdb_test "maint set profile ${boolean_opt}" \ > - "\\&\"maint set profile ${boolean_opt}\\\\n\"\r\n\\^done" \ > - "\"maint set profile ${boolean_opt}\"" > + mi_gdb_test "maint set dwarf2 always-disassemble ${boolean_opt}" \ > + "\\&\"maint set dwarf2 always-disassemble ${boolean_opt}\\\\n\"\r\n\\^done" \ > + "\"maint dwarf2 always-disassemble ${boolean_opt}\"" > } Tom, We replace "maint set profile" with "maint set dwarf2 always-disassemble", because the former will cause gdb to generate a file on exit? > > # Full command parameters are included in the notification when a > diff --git a/gdb/testsuite/gdb.mi/mi-file-transfer.exp b/gdb/testsuite/gdb.mi/mi-file-transfer.exp > index 9229fde..edf1786 100644 > --- a/gdb/testsuite/gdb.mi/mi-file-transfer.exp > +++ b/gdb/testsuite/gdb.mi/mi-file-transfer.exp > @@ -54,15 +54,23 @@ proc mi_gdbserver_run { } { > } > > proc test_file_transfer { filename description } { > - mi_gdb_test "-target-file-put \"$filename\" \"down-server\"" \ > + if {![is_remote host] && ![is_remote target]} { > + set up_server [standard_output_file up-server] > + set down_server [standard_output_file down-server] > + } else { > + set up_server up-server > + set down_server down-server > + } > + IWBN to write comments, IMO. -- Yao (齐尧)