From: Luis Machado <lgustavo@codesourcery.com>
To: Will Newton <will.newton@linaro.org>
Cc: gdb-patches@sourceware.org, patches@linaro.org
Subject: Re: [PATCH] common/linux-ptrace.c: Fix build on non-Intel architectures.
Date: Sat, 24 Aug 2013 21:04:00 -0000 [thread overview]
Message-ID: <52191FD0.6040605@codesourcery.com> (raw)
In-Reply-To: <52190AAD.2050901@linaro.org>
On 08/24/2013 04:34 PM, Will Newton wrote:
>
> As uintptr_t is used stdint.h must be included on all architectures.
>
> 2013-08-24 Will Newton <will.newton@linaro.org>
>
> * common/linux-ptrace.c: Include stdint.h unconditionally.
> ---
> gdb/common/linux-ptrace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/common/linux-ptrace.c b/gdb/common/linux-ptrace.c
> index a4a2ca3..3a8e25e 100644
> --- a/gdb/common/linux-ptrace.c
> +++ b/gdb/common/linux-ptrace.c
> @@ -30,6 +30,8 @@
> #include "gdb_assert.h"
> #include "gdb_wait.h"
>
> +#include <stdint.h>
> +
> /* Stores the currently supported ptrace options. A value of
> -1 means we did not check for features yet. A value of 0 means
> there are no supported features. */
> @@ -64,7 +66,6 @@ extern void (linux_ptrace_test_ret_to_nx_instr) (void);
> #include <sys/reg.h>
> #include <sys/mman.h>
> #include <signal.h>
> -#include <stdint.h>
>
> #endif /* defined __i386__ || defined __x86_64__ */
>
Well spotted.
Thanks,
Luis
next prev parent reply other threads:[~2013-08-24 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-24 19:34 Will Newton
2013-08-24 21:04 ` Luis Machado [this message]
2013-08-26 14:03 ` Agovic, Sanimir
2013-08-26 14:34 ` Pedro Alves
2013-08-28 14:10 ` Will Newton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52191FD0.6040605@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=patches@linaro.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox