From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23832 invoked by alias); 23 Aug 2013 16:50:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23808 invoked by uid 89); 23 Aug 2013 16:50:57 -0000 X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 23 Aug 2013 16:50:55 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7NGoqS6020469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 23 Aug 2013 12:50:53 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7NGopqk017121; Fri, 23 Aug 2013 12:50:51 -0400 Message-ID: <521792EA.3050703@redhat.com> Date: Fri, 23 Aug 2013 16:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: Mark Kettenis , tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [COMMIT] Re: [PATCH] PR gdb/15871: Unavailable entry value is not shown correctly References: <1376379586-24150-1-git-send-email-yao@codesourcery.com> <1376379586-24150-3-git-send-email-yao@codesourcery.com> <87siy4gsn4.fsf@fleche.redhat.com> <521458A8.7060304@codesourcery.com> <5214D03C.9040703@redhat.com> <201308211447.r7LEld3t025510@glazunov.sibelius.xs4all.nl> <5214DD85.5060605@redhat.com> <52156841.8030105@codesourcery.com> <5215E241.6010008@redhat.com> <5216B5C9.3010402@codesourcery.com> In-Reply-To: <5216B5C9.3010402@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00688.txt.bz2 On 08/23/2013 02:07 AM, Yao Qi wrote: > I'd like to write this down in section "Internals" in > http://sourceware.org/gdb/wiki/ProjectIdeas , let me know what do you think. > > Use target_xfer_error instead of errno. Some xfer_memory functions > (such as target_read_memory and deprecated_xfer_memory) are > using errno to indicate any error occurs. This limites what we can > return here, because we can't return some GDB-specific errors, such as > . If we need to indicate an errno, bfd error for example, > a new TARGET_XFER_E_BFD can be added to target_xfer_error. See > http://sourceware.org/ml/gdb-patches/2013-08/msg00589.html for more info. Thanks, but rather than end up with an incomplete transition, I went ahead and did the legwork: http://sourceware.org/ml/gdb-patches/2013-08/msg00687.html deprecated_xfer_memory should just be eliminated. I've now cleaned up remote.c: http://sourceware.org/ml/gdb-patches/2013-08/msg00668.html A few more to go still ... $ grep "deprecated_xfer_memory.*=" *.c | grep -v target.c darwin-nat.c: darwin_ops->deprecated_xfer_memory = darwin_xfer_memory; gnu-nat.c: t->deprecated_xfer_memory = gnu_xfer_memory; go32-nat.c: go32_ops.deprecated_xfer_memory = go32_xfer_memory; monitor.c: monitor_ops.deprecated_xfer_memory = monitor_xfer_memory; nto-procfs.c: procfs_ops.deprecated_xfer_memory = procfs_xfer_memory; procfs.c: t->deprecated_xfer_memory = procfs_xfer_memory; remote-m32r-sdi.c: m32r_ops.deprecated_xfer_memory = m32r_xfer_memory; remote-mips.c: mips_ops.deprecated_xfer_memory = mips_xfer_memory; remote-sim.c: gdbsim_ops.deprecated_xfer_memory = gdbsim_xfer_inferior_memory; windows-nat.c: windows_ops.deprecated_xfer_memory = windows_xfer_memory; -- Pedro Alves