From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9765 invoked by alias); 23 Aug 2013 16:01:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9683 invoked by uid 89); 23 Aug 2013 16:01:20 -0000 X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 23 Aug 2013 16:01:19 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7NG1F5f031496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 23 Aug 2013 12:01:15 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r7NG1CtU023095; Fri, 23 Aug 2013 12:01:13 -0400 Message-ID: <52178748.9070909@redhat.com> Date: Fri, 23 Aug 2013 16:01:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Bernd Bunk CC: tromey@redhat.com, palves@redhat.com, eliz@gnu.org, gdb-patches@sourceware.org Subject: Re: [PATCH v3] Added file properties to windows gdb executable for all mingw32 builds. References: <1377273278-10370-1-git-send-email-bernd.bunk@intel.com> In-Reply-To: <1377273278-10370-1-git-send-email-bernd.bunk@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00685.txt.bz2 On 08/23/2013 04:54 PM, Bernd Bunk wrote: > On Windows OS it is custom that executables and DLL's show file properties. > These contain product name/version, file name/version, company/copyright info. > File properties are visible by right-click on the file, selecting properties \ details. > This patch adds file properties to the gdb executable for all mingw builds. > > 2013-08-14 Bernd Bunk > > * Makefile.in (windows_exe_properties.h): Add rule to create > windows_exe_properties.h header file with file property information. > (windows_exe_properties.o): Added rule to build the resource file. I didn't find where this was updated to write to a temporary file, and then move to the final destination. Did I miss something? > * configure: Add windows_exe_properties.o to mingw32 specific > objects. configure is a generated file. You'll need to edit configure.ac instead. -- Pedro Alves