From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1317 invoked by alias); 22 Aug 2013 19:24:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1283 invoked by uid 89); 22 Aug 2013 19:24:27 -0000 X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 22 Aug 2013 19:24:26 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7MJON2v013298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 22 Aug 2013 15:24:23 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7MJOKWL008702; Thu, 22 Aug 2013 15:24:21 -0400 Message-ID: <52166564.90605@redhat.com> Date: Thu, 22 Aug 2013 19:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Eli Zaretskii CC: Bernd Bunk , tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v2] Added file properties to windows gdb executable for all mingw32 builds. References: <1377161766-8318-1-git-send-email-bernd.bunk@intel.com> <8361uxkbi9.fsf@gnu.org> In-Reply-To: <8361uxkbi9.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00651.txt.bz2 On 08/22/2013 04:09 PM, Eli Zaretskii wrote: > The GNU project doesn't like calling Windows a "win", so I suggest to > rename the files and the script to use something like mingw instead. I'd think this works just as well on Cygwin binaries? I suggest windows-*. "properties" sounds odd to me, given files are usually called resource files. IIRC, the frequent file name used in lots of projects is winres.rc. But then, if you have more than one program in your project, you'd go with gdbres.rc, foores.rc, etc. Which leads me to ... We already have some support for including resources (icon, etc.) in the binary, for gdbtk. See gdb/configure.ac, gdb/Makefile.in and gdbtk/gdb.rc etc. Isn't this going to conflict on gdbtk builds? While at it, follows a review of the patch. > +# shell parameters ... > + > +# default option values > +# keep these defaults in sync with gdb/top.c print_gdb_version() ... > +# check for environment variables to replace certain file properties Please make the comments follow the GNU style. That is, Start sentences with upper case, and end them with a double period. > + Patch this header file using create-win_exe_properties.sh during gdb build > + to customize the file properties. */ Likewise, double period. There may be more instances. > +# keep these defaults in sync with gdb/top.c print_gdb_version() ... > +copyright="Copyright (C) 2013 Free Software Foundation, Inc." That "keep in sync" comment is useless, as nobody will remember to look here when looking at top.c. Instead, remove that, and you'll need to update the "Start of New Year Procedure" section in the internals manual. Guess that means in the wiki now, once this patch is in. > +win_exe_properties.h: Makefile version.in common/create-win_exe_properties.sh > + $(SHELL) $(srcdir)/common/create-win_exe_properties.sh $(srcdir) \ > + "$(host_alias)" "$(target_alias)" win_exe_properties.h It's better to write to a temporary file, and then move to the final destination, so you don't end up with a half baked file if you cancel the build at the wrong time. -- Pedro Alves