From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10824 invoked by alias); 22 Aug 2013 00:18:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10814 invoked by uid 89); 22 Aug 2013 00:18:15 -0000 X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD autolearn=ham version=3.3.2 Received: from mms1.broadcom.com (HELO mms1.broadcom.com) (216.31.210.17) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 22 Aug 2013 00:18:14 +0000 Received: from [10.9.208.53] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Wed, 21 Aug 2013 17:14:06 -0700 X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261 Received: from IRVEXCHSMTP3.corp.ad.broadcom.com (10.9.207.53) by IRVEXCHCAS06.corp.ad.broadcom.com (10.9.208.53) with Microsoft SMTP Server (TLS) id 14.1.438.0; Wed, 21 Aug 2013 17:17:59 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP3.corp.ad.broadcom.com (10.9.207.53) with Microsoft SMTP Server id 14.1.438.0; Wed, 21 Aug 2013 17:17:59 -0700 Received: from [10.177.252.233] (unknown [10.177.252.233]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 3D729F2D73 for ; Wed, 21 Aug 2013 17:17:58 -0700 (PDT) Message-ID: <521558B5.6070909@broadcom.com> Date: Thu, 22 Aug 2013 00:18:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove deprecated_command_loop_hook References: <5215024A.9080709@broadcom.com> <52150D68.6020006@earthlink.net> In-Reply-To: <52150D68.6020006@earthlink.net> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00616.txt.bz2 On 21/08/2013 7:56 PM, Stan Shebs wrote: > On 8/21/13 11:09 AM, Andrew Burgess wrote: >> Small patch to remove deprecated_command_loop_hook. >> >> OK to apply? > > FYI, this hook is essential to gdbtk, which uses it to connect into its > main command loop. It's not obvious to me whether it would be easy or > hard to rewrite gdbtk to not need it. It looks like deprecated_command_loop_hook is used in gdbtk just like it's used in the MI code. I've submitted a patch to gdbtk that removes the use: http://sourceware.org/ml/insight/2013-q3/msg00029.html Thanks, Andrew