From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-104403-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5676 invoked by alias); 19 Aug 2013 13:45:10 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5664 invoked by uid 89); 19 Aug 2013 13:45:10 -0000
X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 19 Aug 2013 13:45:09 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7JDj7k2031176	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 19 Aug 2013 09:45:07 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7JDj567027547;	Mon, 19 Aug 2013 09:45:06 -0400
Message-ID: <52122161.1010108@redhat.com>
Date: Mon, 19 Aug 2013 13:45:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: lgustavo@codesourcery.com
CC: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>,        Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH] Refactor common/target-common into meaningful bits
References: <51FA9649.5060008@codesourcery.com> <520E3BE9.9010402@codesourcery.com>
In-Reply-To: <520E3BE9.9010402@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-08/txt/msg00497.txt.bz2

On 08/16/2013 03:49 PM, Luis Machado wrote:

> This is an updated version of the patch that drops the target-* naming, 
> creates a new directory named "target" under src/gdb and renames the 
> files target-<something>.* to <something.*.
> 
> Based on previous discussions, it seems this is what it should look like 
> in the future.
> 
> One of the differences now is the inclusion of, for example, 
> "target/resume.h" instead of "resume.h". It looks more intuitive this way.

Yes, and the corresponding '#include "wait.h"' would collide with
the system's /usr/include/wait.h.

> -target-common.o: ${srcdir}/common/target-common.c
> -	$(COMPILE) $(srcdir)/common/target-common.c
> +target-waitstatus.o: ${srcdir}/target/waitstatus.c

Any reason this isn't waitstatus.o?

> @@ -550,7 +552,7 @@ filestuff.o: ../common/filestuff.c
>  agent.o: ../common/agent.c
>  	$(COMPILE) $<
>  	$(POSTCOMPILE)
> -target-common.o: ../common/target-common.c
> +target-waitstatus.o: ../target/waitstatus.c
>  	$(COMPILE) $<
>  	$(POSTCOMPILE)

Here too.

Otherwise looks fine to me.

Thanks,
-- 
Pedro Alves