Re: [PATCH] Always print call-clobbered registers in outer frames.

Pedro Alves
2013-09-24T13:43:18Z

On 09/24/2013 01:56 PM, Andrew Burgess wrote:

>>> My question then is, what makes you believe the inner, possibly
>>> call-clobbered value is right?
>>
>> Nothing, of course. It's just a choice -- either assume it's right,
>> and somehow warn the user it may not be right through some other means;
>> or, assume it's not right, and hide the value from the user. If
>> GDB is wrong, the user can still fetch the value, though it'll take
>> more steps (up+p $reg+down, etc.). It might still be a good idea to
>> provide an easier way to "flatten" the not-saved registers as
>> convenience for that, not sure).
>
> I guess the thing I'm struggling with is why would we /ever/ assume the
> value in an inner frame is correct?

"correct" depends on the definition. If we defined registers in
frame > 0 the way I suggested in response to Mark, then they always are.
Doing otherwise means assuming we know the ABI the outer and inner
frames agreed on. There are a number of ways to get that wrong, like
with assembly code, or even probably with gcc attributes or some JITs,
meaning GDB will hide the value from the user behind <not saved>, when
it should not. Granted, not the _usual_ scenario, but I bet it's real.
Yeah, can always be fixed in the unwind/debug itself.

> Sure, for very shallow stacks on
> machines with a non-small register set there's a reasonable chance the
> value is correct, but in any other case I seriously don't see how taking
> the value from an inner frame is any better than picking a random number.

Again, it's a matter of definition -- "taking a value from an
inner frame" just meant "if the unwind info doesn't say the register was
saved, then assume that when the inner function returned, the register
would still hold that value".

> I think that if you print it "they" (users) will use it, assuming it's
> correct. Given that I don't think it's correct I think we're likely to
> be giving users miss-information.

And here is where I'm wondering what sort of use do you think they'll
be giving them. :-) GDB will still print <optimized out> for variables
that happened to be live in such registers at the time of the call. If the
functions involved are C or even higher-level language code, nothing
changes, because indeed if the register is supposedly call-clobbered
nothing in the caller will be expecting to find the old register value
still in the register. But, when you're peeking into machine register values
in the debugger you're going deeper than that. You're probably looking into
mapping them to a disassembly of the machine code. In my mind, at this
level, it's not strictly correct for GDB to assume any particular ABI -- best
be driven by unwind info, and if the unwind info doesn't specify where the
register was saved, at least give the user some useful value, rather than
forcing her to go hunt for it in inner frames.

(Again, I think both perspectives are reasonable. But if the
always-print-registers route is harder to explain to other GDB developers,
then that does hint that users wouldn't understand it either, which does
favor the <not saved> route.)

--
Pedro Alves