Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Will Huang <will.huang@aliyun-inc.com>
Cc: <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH][PR threads/15824] when get threads name failed from info threads with linux kernel version earlier than 2.6.33
Date: Mon, 19 Aug 2013 03:10:00 -0000	[thread overview]
Message-ID: <52118C73.1090604@codesourcery.com> (raw)
In-Reply-To: <000301ce9c87$19927630$4cb76290$@huang@aliyun-inc.com>

On 08/19/2013 10:52 AM, Will Huang wrote:
> +
> +/* Return the string length of FILED /proc/LWPID/task/TID/status.
> +   Return -1 if not found.  */
> +
> +static int
> +linux_proc_get_string (pid_t lwpid, pid_t tid, char *target,
> +                      size_t t_size, const char *field)


I suggest renaming this function to "linux_proc_parse_status" or 
something else, and adjust the comment.

/* Parse file /proc/LWPID/task/TID/status, save the value of FIELD
    in buffer TARGET, whose length is T_SIZE, and return the length
    of the value.  If TID is zero, parse /proc/LWPID/status instead.
    Return -1 if not found.  */

static int
linux_proc_parse_status (pid_t lwpid, pid_t tid, char *target,
                          size_t t_size, const char *field)
-- 
Yao (齐尧)


  reply	other threads:[~2013-08-19  3:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14  4:27 Will Huang
2013-08-16  2:26 ` Yao Qi
2013-08-16  5:32   ` Will Huang
2013-08-16  9:38     ` Yao Qi
2013-08-16 10:22       ` Will Huang
2013-08-16 11:29         ` Yao Qi
2013-08-16 16:24           ` Pedro Alves
2013-08-19  2:52           ` Will Huang
2013-08-19  3:10             ` Yao Qi [this message]
2013-08-19  5:01               ` Will Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52118C73.1090604@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=will.huang@aliyun-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox