From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24746 invoked by alias); 17 Aug 2013 04:01:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24732 invoked by uid 89); 17 Aug 2013 04:01:34 -0000 X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MISSING_HEADERS,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=no version=3.3.2 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 17 Aug 2013 04:01:32 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VAXhi-0004md-C4 from Luis_Gustavo@mentor.com ; Fri, 16 Aug 2013 21:01:30 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 16 Aug 2013 21:01:30 -0700 Received: from [172.30.2.164] ([172.30.2.164]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 16 Aug 2013 21:01:29 -0700 Message-ID: <520EF596.9020307@codesourcery.com> Date: Sat, 17 Aug 2013 04:01:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 CC: "'gdb-patches@sourceware.org'" , Pedro Alves , Tom Tromey Subject: Re: [PATCH] Refactor common/target-common into meaningful bits References: <51FA9649.5060008@codesourcery.com> <520E3BE9.9010402@codesourcery.com> In-Reply-To: <520E3BE9.9010402@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00454.txt.bz2 I see some gotchas with this patch (on Makefile.in etc). I'll get those fixed and will submit an updated version. On 08/16/2013 11:49 AM, Luis Machado wrote: > Hi, > > This is an updated version of the patch that drops the target-* naming, > creates a new directory named "target" under src/gdb and renames the > files target-.* to > Based on previous discussions, it seems this is what it should look like > in the future. > > One of the differences now is the inclusion of, for example, > "target/resume.h" instead of "resume.h". It looks more intuitive this way. > > Ok? > > Luis > > On 08/01/2013 02:09 PM, Luis Machado wrote: >> Hi, >> >> After the previous discussion >> (http://sourceware.org/ml/gdb-patches/2013-07/msg00840.html), follows a >> patch to refactor the ill-named target-common.[c|h] files into something >> a bit more meaningful. >> >> First, it seems like a good idea to stablish a more meaningful >> directory structure as well, so we are moving target-common.[c|h] from >> the "common" dir to the new "target" dir. This new directory will hold >> anything more backend-related. For now it contains only generic target >> definitions and functions. >> >> I've broken target-common.[c|h] into the following: >> >> - target-resume.h: Definition for resume_kind. >> >> - target-waitstatus.[c|h]: Definitions and code for anything related to >> waitstatus. >> >> - target-wait.h: A tiny bit that does not seem to fit properly in the >> waitstatus files, so it is left here. >> >> As usual, Makefile and other dependencies have been adjusted. Everything >> builds fine and does not show any regressions. >> >> The copyright headers have been adjusted and cleaned up to remove >> contribution messages. >> >> Comments over 70 columns have also been adjusted for this patch. >> >> Thoughts? >> >> Luis >