From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22983 invoked by alias); 16 Aug 2013 14:21:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22974 invoked by uid 89); 16 Aug 2013 14:21:56 -0000 X-Spam-SWARE-Status: No, score=-8.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 16 Aug 2013 14:21:56 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7GELqBe019518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 16 Aug 2013 10:21:52 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r7GELoQU011463; Fri, 16 Aug 2013 10:21:51 -0400 Message-ID: <520E357E.6080803@redhat.com> Date: Fri, 16 Aug 2013 14:21:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Eli Zaretskii CC: yao@codesourcery.com, gdb-patches@sourceware.org, brobecker@adacore.com Subject: Re: [PATCH] Unbuffer stdout and stderr on windows References: <51EE23F8.1070905@codesourcery.com> <83wqohw4ee.fsf@gnu.org> <20130729192559.GA5348@ednor.casa.cgf.cx> <83d2q1xiyv.fsf@gnu.org> <51F6C7B2.3020400@redhat.com> <20130731034045.GA5565@ednor.casa.cgf.cx> <20130812211105.GA11128@adacore.com> <8361v9piop.fsf@gnu.org> <20130815173618.GA6955@ednor.casa.cgf.cx> <83eh9uonlg.fsf@gnu.org> <20130815175940.GD6955@ednor.casa.cgf.cx> <520E1109.7000304@redhat.com> <520E1C34.2000907@codesourcery.com> <520E2B13.8020706@redhat.com> <83r4dtn35q.fsf@gnu.org> In-Reply-To: <83r4dtn35q.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00433.txt.bz2 On 08/16/2013 03:03 PM, Eli Zaretskii wrote: > I suggest not to broaden the issue beyond the original problem, lest > we will be unable to solve it. Nobody's doing that. What I'm saying is that the testsuite is not special, and we should _zone in_ to the real problem, and fix it completely. Making output not buffered seems to do that, assuming GDB doesn't output half a line to stdout, then output to stderr, and then output the rest to stderr, which very much it will want to avoid, given stderr is unbuffered on most systems. If the output is buffered, then something must be forcing flushes to get the same effect. Fixing the issue for the testsuite but not for other GDB-consumers that spawn it in a pipe, with special modes is just not the right solution, IMO. What will probably happen with that solution is that Windows GDB clients will end up using the special testsuite-only flag too, because by default, GDB will remain broken... Why add a flag for a half-fix instead of fixing the issue completely? -- Pedro Alves