From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11103 invoked by alias); 13 Aug 2013 14:28:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11088 invoked by uid 89); 13 Aug 2013 14:28:32 -0000 X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 13 Aug 2013 14:28:31 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7DESU3S023397 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 13 Aug 2013 10:28:30 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7DESSZw012181; Tue, 13 Aug 2013 10:28:29 -0400 Message-ID: <520A428C.2070505@redhat.com> Date: Tue, 13 Aug 2013 14:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Burgess CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] undefined printf format crashes gdb References: <520A2D08.4080600@broadcom.com> In-Reply-To: <520A2D08.4080600@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00342.txt.bz2 On 08/13/2013 01:56 PM, Andrew Burgess wrote: > Current gdb HEAD: > > (gdb) printf "%#p", 0 > ./printcmd.c:2655: internal-error: ui_printf: Assertion `*p == 'p' && *(p + 1) == '\0'' failed. > A problem internal to GDB has been detected, > further debugging may prove unreliable. > Quit this debugging session? (y or n) y > > With my patch: > > (gdb) printf "%#p", 0 > Inappropriate modifiers to format specifier 'p' in printf > > The man page for printf (on my machine) says # on pointers is undefined, > but my undefined seems better than the current undefined :) > > OK to apply? OK. Thanks, -- Pedro Alves