From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11579 invoked by alias); 13 Aug 2013 08:12:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11557 invoked by uid 89); 13 Aug 2013 08:12:16 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.2 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 13 Aug 2013 08:12:15 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1V99i9-0001iv-Ap from Yao_Qi@mentor.com ; Tue, 13 Aug 2013 01:12:13 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 13 Aug 2013 01:12:13 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Tue, 13 Aug 2013 01:12:12 -0700 Message-ID: <5209EA1F.5040709@codesourcery.com> Date: Tue, 13 Aug 2013 08:12:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pierre Muller CC: Subject: Re: [PATCH 1/3] Detect GDB is in cygwin References: <83txjdxtpd.fsf@gnu.org> <51F786CB.3020700@codesourcery.com> <83a9l4xdst.fsf@gnu.org> <51FA137B.6070207@codesourcery.com> <20130803045452.GA997@ednor.casa.cgf.cx> <51FE1493.9070707@codesourcery.com> <20130805044122.GA1825@ednor.casa.cgf.cx> <51FF4483.5000102@codesourcery.com> <20130806020839.GA3362@ednor.casa.cgf.cx> <520067CB.4000300@codesourcery.com> <20130808051114.GA1553@ednor.casa.cgf.cx> <000301ce9408$d51ed560$7f5c8020$@muller@ics-cnrs.unistra.fr> In-Reply-To: <000301ce9408$d51ed560$7f5c8020$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-08/txt/msg00330.txt.bz2 On 08/08/2013 03:28 PM, Pierre Muller wrote: > Without mintty (running Cygwin bash directly), I do get a FILE_TYPE_CHAR, > and a second check by calling GetConsoleMode with the same handle > allows to verify that it is indeed a Windows OS Console handle. > > I think that there is indeed no good way to know if we are using > a non-interactive pipe... > As the primary purpose of the patch was to allow better results for the > testsuite > for mingw builds, I think that the idea > of adding a > "maint set testsuite-mode on/off" > command that could be > automatically added to > INTERNAL_GDBFLAGS as "-iex {maint set testsuite-mode on}" > would be a simpler approach. > It would guaranty that we do not change existing behavior for > interactive GDB use and should solve the problem about ^M^M patterns that > lead to lots of failures when testing mingw builds. > As I explained earlier, this changes are also required if you want > to run the testsuite on msys terminal. > > Should I prepare a RFC? > Pierre, Yes, I think so, but before you post it, we have to coordinate on this. Two people (you and I) post the similar-but-different patches may confuse maintainers and doesn't help on review and approval on any of them. There are some issues related to mingw and cygwin, and we (you and I) are working on some of them, with different focus. If you don't mind, I'll post my patches again, a fresh version, V4, and hopefully maintainers can approve them this time. In the review of V3, all the questions were addressed, AFAIK, but no one approved it explicitly. Then, you can prepare your RFC, and I am happy to help (review and test). Is it OK to you? > One question about this new command that I had in mind > was about the scope of this command. > Should I put it inside mingw-hdep.c code and restrict it to > mingw builds, or should I introduce that command globally, > the posix-tdep.c version would be an empty function for now, > but could be useful (?) later. I prefer the former one. > The advantage of the second approach is that we could add > the "-iex {maint set testsuite-mode on}" unconditionally in gdb.exp, > but that might seem like a weak argument... You can modify your board file or build_dir/gdb/testsuite/site.exp to append the option to GDBFLAGS. -- Yao (齐尧)