From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26271 invoked by alias); 12 Aug 2013 14:01:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26250 invoked by uid 89); 12 Aug 2013 14:01:40 -0000 X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD autolearn=ham version=3.3.2 Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 12 Aug 2013 14:01:39 +0000 Received: from [10.9.208.53] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Mon, 12 Aug 2013 06:55:22 -0700 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS06.corp.ad.broadcom.com (10.9.208.53) with Microsoft SMTP Server (TLS) id 14.1.438.0; Mon, 12 Aug 2013 07:01:31 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Mon, 12 Aug 2013 07:01:31 -0700 Received: from [10.177.73.61] (unknown [10.177.73.61]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id EB7CFF2E99; Mon, 12 Aug 2013 07:01:06 -0700 (PDT) Message-ID: <5208EAA1.7020109@broadcom.com> Date: Mon, 12 Aug 2013 14:01:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "Pedro Alves" cc: gdb-patches@sourceware.org, "Mark Kettenis" Subject: Re: [PATCH] Consistent display of "" References: <5200F55E.2050308@broadcom.com> <201308061318.r76DIMdd016369@glazunov.sibelius.xs4all.nl> <5200FECF.7030304@broadcom.com> <201308061541.r76FfYQN022875@glazunov.sibelius.xs4all.nl> <520142D9.4030304@redhat.com> <5208E3C8.7060107@broadcom.com> <5208E938.3080305@redhat.com> In-Reply-To: <5208E938.3080305@redhat.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00317.txt.bz2 On 12/08/2013 2:55 PM, Pedro Alves wrote: > On 08/12/2013 02:31 PM, Andrew Burgess wrote: >> On 06/08/2013 7:39 PM, Pedro Alves wrote: >>> On 08/06/2013 04:41 PM, Mark Kettenis wrote: >>>>> Date: Tue, 6 Aug 2013 14:49:03 +0100 >>>>> From: "Andrew Burgess" >>> >>>>> 3. My understanding was that values lost due to the ABI of a call site >>>>> were recorded as optimized out. For evidence I would present >>>>> dwarf2_frame_prev_register, and how DWARF2_FRAME_REG_UNDEFINED is handled. >>>>> >>>>> For these reasons I believe my patch should still be considered, what do >>>>> you think? >>>> >>>> I think that registers are either available or unavailble. A register >>>> being unavailble implies that a variable that is supposed to live in >>>> such a register may have been optimized out. Whether GDB's pseudo >>>> variables that respresent registers are considered unavailable or >>>> optimized out in that case is arguable. >>> >>> I think improving consistency as in Andrew's patch is good. >> >> Given almost a week has passed with no further feedback I plan to >> commit this patch tomorrow unless there's any further discussion to be had. > > TBC, note my opinion doesn't get to overrule Mark's. Consensus > works much better, and Mark does have deep knowledge of all > ABI/pseudo registers/etc. gdb things. > That said, Mark, if you still disagree, please counter argue, > otherwise, we'll just have to assume you do agree with the > rationales and clarifications. In any case, Andrew, please wait > until someone gives the patch an OK. I did not look at the patch at > all in any detail, and/or whether it actually follows the guidelines > I presented. Thanks for the reply. This is why I posted before committing, I wasn't sure quite what state this patch was in. I'm more than happy to wait. Cheers, Andrew