Re: [PATCH] Fix for PR15117

Tom Tromey
2013-08-07T20:01:21Z

>>>>> "Ali" == ali anwar <ali_anwar@codesourcery.com> writes:

Ali> Thank you for reviewing the patch again.

It's customary to always send the ChangeLog entry when re-sending a
patch.

I personally do this by putting the ChangeLog entry into the git commit
and using git send-email, but there are many ways to manage it.

The patch is ok with the ChangeLog from up-thread.

FWIW I am not especially fond of convenience variables in linespecs.
They seem odd to me. Like, won't the breakpoint move at re-set if the
variable changes? Also I note that they aren't documented... But your
patch is just fixing an error in the existing support, which I think
makes it ok to go in.

thanks,
Tom