From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8050 invoked by alias); 8 Aug 2013 14:24:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8015 invoked by uid 89); 8 Aug 2013 14:24:02 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 08 Aug 2013 14:24:01 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r78ENrSo009251 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Aug 2013 10:23:53 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r78ENpeF003014; Thu, 8 Aug 2013 10:23:52 -0400 Message-ID: <5203A9F7.5060907@redhat.com> Date: Thu, 08 Aug 2013 14:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH] Only print entry values for arguments. References: <1375663450-5825-1-git-send-email-yao@codesourcery.com> <51FFB2A5.8040005@redhat.com> <52033CB7.3070202@codesourcery.com> In-Reply-To: <52033CB7.3070202@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00240.txt.bz2 >> Otherwise it looks good to me. I wonder whether we should put >> this in 7.6.1 ? > > This problem exists on 7.6 branch too, > > (gdb) interpreter-exec mi "-stack-list-locals 2" > ^done,locals=[{name="b",type="int",value="2"}] > (gdb) set print entry-values only > (gdb) interpreter-exec mi "-stack-list-locals 2" > ^done,locals=[{name="b@entry",type="int",value=""}] > > We can apply this patch to 7.6 branch except the test case part, > because gdb.trace/mi-trace-unavailable.exp doesn't exist on 7.6 > branch. If we run 7.6 against that test pristine would it pass cleanly? > I plan to > 1) cvs -d :ext:qiyao@sourceware.org:/cvs/src co -r gdb_7_6-branch gdb > 2) apply this patch without changes to gdb.trace/mi-trace-unavailable.exp > > Since it is not a bug fix, don't have to mention it in > http://sourceware.org/gdb/wiki/GDB_7.6_Release . Hmm. If this is issue is present in the 7.6 branch, how is it not a bug fix? Instead, what we should do if the bug wasn't reported in bugzilla, is file one, so we can reference it from the wiki. > If my understanding > is right, I'll commit the patch to 7.6 branch. -- Pedro Alves