From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9438 invoked by alias); 8 Aug 2013 06:50:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9429 invoked by uid 89); 8 Aug 2013 06:50:46 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 08 Aug 2013 06:50:46 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1V7K3S-0005EA-7F from Yao_Qi@mentor.com ; Wed, 07 Aug 2013 23:50:38 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 7 Aug 2013 23:50:38 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Wed, 7 Aug 2013 23:50:29 -0700 Message-ID: <52033F8A.4020809@codesourcery.com> Date: Thu, 08 Aug 2013 06:50:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH] Set entryval_error to NULL if entryval is set References: <1375690566-7417-1-git-send-email-yao@codesourcery.com> <874nb4b5b3.fsf@fleche.redhat.com> In-Reply-To: <874nb4b5b3.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-08/txt/msg00232.txt.bz2 On 08/05/2013 10:06 PM, Tom Tromey wrote: > The bug fix part looks ok to me, but I think you need a special test > case in order to really test entry values. Or to put it another way, > what happens if this test is run with a compiler that doesn't emit entry > value information? Tom, Patch in gdb.trace/collection.exp is to test arguments and/or entry values are shown properly, without the internal error. Testing the contents of entry values is not the point of this test and the patch. AFAIK, entry values is tested by gdb.arch/amd64-entry-value.exp. -- Yao (齐尧)