On 08/02/2013 10:49 PM, Keith Seitz wrote:
>
> Two tiny nits:
>
>> +        {
>> +          /* Not able to parse user specified variable. Do not
>> +         throw an error here. parse_linespec will do it for us*/
>
> This comment is not formatted properly: two spaces after '.'. Use
> complete sentences (where possible/feasible). This should probably read:
>
> /* The user-specified variable was not valid.  Do not
>     throw an error here.  parse_linespec will do it for us.  */
>
> [i.e, just copy the bits from the following block]

Fixed.

>> +# Test break via convenience variable with file name
>> +#
>> +set line [gdb_get_line_number "set breakpoint 1 here"]
>> +gdb_test_no_output "set \$l = $line"
>
> I'm showing extra whitespace at the end of the above line.  Could you
> double-check that before committing?
>

Fixed.

> With those trivial things fixed, I think this patch is ready for a
> global maintainer to review and approve.
>

Thank you for reviewing the patch again.

Regards,
-Ali