From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83760 invoked by alias); 27 Apr 2017 16:05:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83739 invoked by uid 89); 27 Apr 2017 16:05:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Consistently, one's X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Apr 2017 16:05:34 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D6CD161982; Thu, 27 Apr 2017 16:05:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D6CD161982 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D6CD161982 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id F242777EFC; Thu, 27 Apr 2017 16:05:33 +0000 (UTC) Subject: Re: [PATCH 3/4] Consistently use fprintf_filtered when displaying MIPS registers. To: Luis Machado , John Baldwin , gdb-patches@sourceware.org References: <20170412183727.22483-1-jhb@FreeBSD.org> <20170412183727.22483-4-jhb@FreeBSD.org> <8eadfc97-f4ec-8c89-f193-f96a2fa8839c@codesourcery.com> From: Pedro Alves Message-ID: <51dd8603-3681-c0fb-618d-29757e7c4b74@redhat.com> Date: Thu, 27 Apr 2017 16:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8eadfc97-f4ec-8c89-f193-f96a2fa8839c@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00743.txt.bz2 On 04/13/2017 05:29 PM, Luis Machado wrote: > On 04/12/2017 01:37 PM, John Baldwin wrote: >> One line was using printf_filtered instead of fprintf_filtered >> to the requested file. >> >> gdb/ChangeLog: >> >> * mips-tdep.c (print_gp_register_row): Replace printf_filtered >> with fprintf_filtered. >> --- >> gdb/ChangeLog | 5 +++++ >> gdb/mips-tdep.c | 2 +- >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >> index 73d24d2c9d..f1ac925fec 100644 >> --- a/gdb/ChangeLog >> +++ b/gdb/ChangeLog >> @@ -1,5 +1,10 @@ >> 2017-04-11 John Baldwin >> >> + * mips-tdep.c (print_gp_register_row): Replace printf_filtered >> + with fprintf_filtered. >> + >> +2017-04-11 John Baldwin >> + >> * mips-fbsd-tdep.c (MIPS_PC_REGNUM): Remove. >> (MIPS_FP0_REGNUM): Remove. >> (MIPS_FSR_REGNUM): Remove. >> diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c >> index 41cb9d82c6..674b5098b0 100644 >> --- a/gdb/mips-tdep.c >> +++ b/gdb/mips-tdep.c >> @@ -6539,7 +6539,7 @@ print_gp_register_row (struct ui_file *file, >> struct frame_info *frame, >> for (byte = 0; >> byte < (mips_abi_regsize (gdbarch) >> - register_size (gdbarch, regnum)); byte++) >> - printf_filtered (" "); >> + fprintf_filtered (file, " "); >> /* Now print the register value in hex, endian order. */ >> if (gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG) >> for (byte = >> > > This one seems trivial enough. I have no comments. Agreed. This one's obviously correct. Please push it in. Thanks, Pedro Alves