From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8275 invoked by alias); 2 Aug 2013 20:14:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8263 invoked by uid 89); 2 Aug 2013 20:14:25 -0000 X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO elasmtp-banded.atl.sa.earthlink.net) (209.86.89.70) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 02 Aug 2013 20:14:25 +0000 Received: from [68.96.200.16] (helo=macbook2.local) by elasmtp-banded.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1V5Ljt-0006Tm-Ea for gdb-patches@sourceware.org; Fri, 02 Aug 2013 16:14:17 -0400 Message-ID: <51FC1311.2000909@earthlink.net> Date: Fri, 02 Aug 2013 20:14:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFC] TI msp430 architecture support References: <20130516200050.17ab3ae7@mesquite.lan> <20130517062911.GE4017@adacore.com> <20130624185342.29e671a3@pinnacle.lan> <87txkmtghb.fsf@fleche.redhat.com> <20130625085137.4317c9b8@pinnacle.lan> In-Reply-To: <20130625085137.4317c9b8@pinnacle.lan> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da94018f9f97e112ad5926443603e79f063ac350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-SW-Source: 2013-08/txt/msg00112.txt.bz2 On 6/25/13 8:51 AM, Kevin Buettner wrote: > On Tue, 25 Jun 2013 08:25:20 -0600 > Tom Tromey wrote: > >>>>>>> "Kevin" == Kevin Buettner writes: >> >> Kevin> I fixed the formatting issues that you noticed and then, for >> Kevin> good measure, I ran the file through gdb_indent.sh. I should've >> Kevin> run gdb_indent.sh over msp430-tdep.c prior to submitting it. >> >> I didn't know anybody used gdb_indent.sh. Was this a one-off thing or >> have you run it regularly on other source files? > > There was a time when the output of GNU indent was considered the > standard for GDB indentation. If there was any disagreement about > correct indentation, a contributor would be asked to run GNU indent > over the code. The problem is, of course, that different options > produce different results which is how gdb_indent.sh came into being. > > My recollection is that there were at least two occasions when > significant portions of the gdb source tree were reindented. (This > may have pre-dated the creation of gdb_indent.sh, however.) I don't > think that mass reindentation should be done very often because it > causes a lot more work for folks who have developed significant > changes prior to the the reindenation occurring. I think it can make > sense for newly contributed files, however. > > Kevin > In the past when I've run GNU indent on GDB, its results were reasonable, but subtly different from Emacs region indents; so while indent was a good tool to clean up messes, Emacs users were going to find code formatting changing around them unexpectedly. The script came later, I don't know if its options fix that problem. (I never discovered a combination of options that exactly matched Emacs behavior.) Stan stan@codesourcery.com