Re: [PATCH v2 3/4] add caching procs to test suite

Pedro Alves
2013-08-02T17:23:40Z

On 08/02/2013 05:48 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> On 08/02/2013 04:36 PM, Tom Tromey wrote:
>>> - set src complex[pid].c
>>> - set exe complex[pid].x
>>> + set src [standard_temp_file complex[pid].c]
>>> + set exe [standard_temp_file complex[pid].x]
>
> Pedro> Hmm. Are these uses of standard_temp_file really
> Pedro> related to the caching mechanism?
>
> Not really. I can push them into patch 2 if you want.

I always prefer logically independent changes split into
independent patches, as it makes it much easier to
understand a patch and its ramifications (post-checkin too, when
doing archaelogy and regression culprit finding), but I don't
want to insist.

--
Pedro Alves