On 07/29/13 10:48, Tom Tromey wrote: >>>>>> "Michael" == Michael Eager writes: > > Tom> FWIW there isn't much need to add new annotations. Annotations are > Tom> officially deprecated. It's fine by me if you want to leave this in for > Tom> some reason though. > > Michael> I added the annotations at your request (4/19/13): > > Tom>> I think for MI it is better to make this a real field. > Tom>> Also I wonder whether this should be emitted unconditionally if > Tom>> mi-like. Say: > > Michael> Perhaps I misunderstood what you meant by "make this a real field". > > Yeah, I'm sorry I wasn't clearer. > > "annotations" refers to annotate.[ch] and the corresponding command-line > option. This is an old way to communicate gdb state changes to a GUI, > mainly Emacs. > > By "a real field" I meant using ui_out_*. > > Michael> + ui_out_text (uiout, linkname); > > Tom> This is emitting the linkage name using ui_out_text. That is wrong for > Tom> MI. > > It maybe wasn't clear but I was referring to the quoted line above when > I said this. > > Michael> What should it be? ui_out_field_string()? Something else? > > Yes, ui_out_field_string. I eliminated the annotations and made the other requested changes. gdb/ 2013-08-01 Michael Eager * NEWS: Announcement. * ada-lang.c: Update calls to find_frame_funname. * disasm.c: Likewise. * python/py-frame.c: Likewise. * breakpoint.c (print_breakpoint_location): Print linkage name. * defs.h (build_address_symbolic): Add linkname arg. * printcmd.c (print_address_symbolic): Print linkage name. (build_address_symbolic): Return linkage name. * stack.c (find_frame_funname): Return linkage name. (print_frame): Print linkage name. * stack.h (find_frame_funname): Update declaration. * top.c (display_linkage_name, display_linkage_name_length): New. (show_display_linkage_name, show_display_linkage_name_length): New cmds. * top.h (display_linkage_name, display_linkage_name_length): Declare. gdb/doc 2013-08-01 Michael Eager * gdb.texinfo: Add description. gdb/testsuite 2013-08-01 Michael Eager * gdb.cp/display-linkage-name.exp: New. * gdb.cp/display-linkage-name.cc: New. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077