From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6692 invoked by alias); 1 Aug 2013 17:52:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6683 invoked by uid 89); 1 Aug 2013 17:52:48 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 01 Aug 2013 17:52:48 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1V4x3I-0006vA-9d from Luis_Gustavo@mentor.com ; Thu, 01 Aug 2013 10:52:40 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 1 Aug 2013 10:52:40 -0700 Received: from [172.30.15.233] ([172.30.15.233]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 1 Aug 2013 10:52:39 -0700 Message-ID: <51FAA061.4050005@codesourcery.com> Date: Thu, 01 Aug 2013 17:52:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: "'gdb-patches@sourceware.org'" , Pedro Alves Subject: Re: [PATCH] Refactor common/target-common into meaningful bits References: <51FA9649.5060008@codesourcery.com> <87vc3pfghs.fsf@fleche.redhat.com> In-Reply-To: <87vc3pfghs.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00042.txt.bz2 On 08/01/2013 02:49 PM, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado writes: > > Luis> First, it seems like a good idea to stablish a more meaningful > Luis> directory structure as well, so we are moving target-common.[c|h] from > Luis> the "common" dir to the new "target" dir. This new directory will hold > Luis> anything more backend-related. For now it contains only generic target > Luis> definitions and functions. > > I like it. > > Luis> I've broken target-common.[c|h] into the following: > Luis> - target-resume.h: Definition for resume_kind. > Luis> - target-waitstatus.[c|h]: Definitions and code for anything related > Luis> to waitstatus. > Luis> - target-wait.h: A tiny bit that does not seem to fit properly in the > Luis> waitstatus files, so it is left here. > > If I may be permitted to bikeshed just a bit longer... > > Right now the file is named "target/target-waitstatus.h" and the code > says: > > +#include "target-waitstatus.h" > > > I wonder whether you considered naming the file "target/waitstatus.h" > and having the code say: I did and it does sound more intuitive, but i didn't want to turn too many knobs at a time. If others are OK with this, i can make that change.