From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15846 invoked by alias); 1 Aug 2013 14:47:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15820 invoked by uid 89); 1 Aug 2013 14:47:57 -0000 X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 01 Aug 2013 14:47:57 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r71ElmOO020985 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 1 Aug 2013 10:47:48 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r71ElkO1029303; Thu, 1 Aug 2013 10:47:47 -0400 Message-ID: <51FA7512.6000807@redhat.com> Date: Thu, 01 Aug 2013 14:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Add options to skip unavailable locals References: <1372816106-15942-1-git-send-email-yao@codesourcery.com> <1372816106-15942-3-git-send-email-yao@codesourcery.com> <83vc4ra1ps.fsf@gnu.org> <51EC8CCE.7020007@codesourcery.com> <51FA557F.5@redhat.com> <51FA69AA.6050805@codesourcery.com> In-Reply-To: <51FA69AA.6050805@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00025.txt.bz2 On 08/01/2013 02:59 PM, Yao Qi wrote: > On 08/01/2013 08:33 PM, Pedro Alves wrote: >> I don't think this has been updated right for entry values. With >> entry values, we now have_two_ values to account for. I think >> we need to do this once for each of the regular arg and the >> entry arg? >> > > OK, will update the patch to handle both regular arg and entry value. > > Is it possible that one is available and the other is not? Sure. The debug info just tells us where to fetch the entry value from (registers, memory, etc.) just like the regular arg. So it'll depend on which chunks of memory/registers have been collected. > If yes, > when option '--skip-unavailable' is used, some thing we have to think about, > > 1. if regular arg is available but entry is unavailable, like this, > > > {name="j",type="int",value="4"},{name="j@entry",type="int",value=""} > > what is the expected output? how about displaying regular arg only as > it is available? like: > > {name="j",type="int",value="4"} > > 2. if entry is available but regular arg is not, like this, > > > {name="j",type="int",value=""},{name="j@entry",type="int",value="4"} > > what is the expected output? how about displaying entry value only as it > is available? like: > > {name="j@entry",type="int",value="4"} > Yes, that's what I'd expect. -- Pedro Alves