Re: [PATCH] Share more common target structures between gdb and gdbserver

[Pedro Alves <palves@redhat.com>]

On 07/16/2013 07:49 PM, Luis Machado wrote:
> Hi,
> 
> While doing some research about the remote fork following feature, i 
> noticed there was some duplication of target data structures for GDB and 
> gdbserver.
> 
> This patch moves the shareable code/data structures to 
> common/target-common.* and makes both GDB and gdbserver target files 
> reference the header common/target-common.h.
> 
> Makefiles and other files have been adjusted accordingly.

I'd very much prefer avoiding "common" in file names, instead
naming the files for what they contain, not for the fact that they're
"common" to two programs (gdb, gdbserver) presently.  I think of it
this way -- when we finally end up with only one backend (or one
backend using a foo-common.c file), I'd rather avoid
renaming these files to something else, because they're no longer
"common".  Or, yet IOW, think of common/ as a library.  Can you
imagine if all libraries in a distro named their implementation
files "foo-common.c" ?  Because that's what should happen given
they're used by lots of programs, right?  :-)  The direction I prefer
is, when moving things to common/ we take the opportunity to split them
into smaller, more atomic, leaner units.  E.g., that's how we ended up
with ptid.h/ptid.c, instead of inferior-common.h (or some such).

If the file is just a dumping ground of misc things, then let's at
least call it that.  Say, target-misc.h or target-defs.h.

Otherwise, this looks good to me.

On 07/16/2013 07:49 PM, Luis Machado wrote:
> +++ b/gdb/common/target-common.h
> @@ -0,0 +1,153 @@
> +/* Interface between the debugger and target environments, including files
> +   and processes, shared between GDB and gdbserver.
> +
> +   Copyright (C) 1990-2013 Free Software Foundation, Inc.
> +
> +   Contributed by Cygnus Support.  Written by John Gilmore.

(I have absolutely nothing again John, but this shows how
"contributed by"/"written by" lines are a disservice to future
hackers, IMO.  Lot's of code here that others wrote.)

-- 
Pedro Alves