From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5557 invoked by alias); 30 Jul 2013 17:15:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5529 invoked by uid 89); 30 Jul 2013 17:15:55 -0000 X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO e24smtp03.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Jul 2013 17:15:51 +0000 Received: from /spool/local by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 30 Jul 2013 14:15:39 -0300 Received: from d24dlp02.br.ibm.com (9.18.248.206) by e24smtp03.br.ibm.com (10.172.0.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 30 Jul 2013 14:15:37 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 6ABDE1DC0068 for ; Tue, 30 Jul 2013 13:15:36 -0400 (EDT) Received: from d24av03.br.ibm.com (d24av03.br.ibm.com [9.8.31.95]) by d24relay02.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6UHE3eY24117304 for ; Tue, 30 Jul 2013 14:14:03 -0300 Received: from d24av03.br.ibm.com (localhost [127.0.0.1]) by d24av03.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r6UHFZwZ009653 for ; Tue, 30 Jul 2013 14:15:36 -0300 Received: from [9.18.235.139] (grandaddy.br.ibm.com [9.18.235.139]) by d24av03.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r6UHFZcH009644; Tue, 30 Jul 2013 14:15:35 -0300 Message-ID: <51F7F4B7.7020303@linux.vnet.ibm.com> Date: Tue, 30 Jul 2013 17:15:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Anton Blanchard CC: gdb-patches@sourceware.org, brobecker@adacore.com, luis_gustavo@mentor.com Subject: Re: [PATCH 1/3] Fix ppc64 single step over atomic sequence testcase References: <20130729173838.36f370a6@kryten> In-Reply-To: <20130729173838.36f370a6@kryten> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13073017-9254-0000-0000-00000D33AAEE X-SW-Source: 2013-07/txt/msg00781.txt.bz2 On 07/29/2013 04:38 AM, Anton Blanchard wrote: > > (My apologies, I thought I'd got these patches merged but obviously I > hadn't). > > The current ppc64 single step over atomic sequence testcase is broken. > Convert the test into assembly and use stepi to step through it. Hi Anton, thanks for reworking this patch! I do recall we discussed this in the mailing list last year (http://sourceware.org/ml/gdb-patches/2012-06/msg00162.html). > > Anton > -- > > 2013-07-29 Anton Blanchard > > * gdb.arch/ppc64-atomic-inst.c: Remove > * gdb.arch/ppc64-atomic-inst.s: New file > * gdb.arch/ppc64-atomic-inst.exp: Adapt for asm based testcase > (just a nitpick: missing period at the end of the lines.) > Index: gdb/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp > =================================================================== > --- gdb.orig/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp > +++ gdb/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp > @@ -27,9 +27,9 @@ if {![istarget "powerpc*"] || ![is_lp64_ > } > > set testfile "ppc64-atomic-inst" > -set srcfile ${testfile}.c > +set srcfile ${testfile}.s > set binfile ${objdir}/${subdir}/${testfile} > -set compile_flags {debug quiet} > +set compile_flags "debug quiet additional_flags=-I${srcdir}/gdb.asm" I've noticed it fails to build with the following: spawn -ignore SIGHUP gcc ../../../gdb.git/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s -I../../../gdb.git/gdb/testsuite/gdb.asm -g -lm -o /home/emachado/gdb/build/gdb/testsuite/gdb.arch/ppc64-atomic-inst^M ../../../gdb.git/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s: Assembler messages:^M ../../../gdb.git/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s:1: Error: can't open common.inc for reading: No such file or directory^M ../../../gdb.git/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s:2: Error: can't open powerpc64.inc for reading: No such file or directory^M ../../../gdb.git/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s:5: Error: Unrecognized opcode: `gdbasm_declare'^M compiler exited with status 1 This seems to happen because -I option is not passed to the assembler. I've tried adding this parameter using -Wa as: set compile_flags "debug quiet additional_flags=-Wa,-I${srcdir}/gdb.asm" and it fixes the build failure. With this change, the testcase passes OK, also including the other 2 patches you sent on this thread. Thanks and regards, -- Edjunior