From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29966 invoked by alias); 30 Jul 2013 16:10:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29957 invoked by uid 89); 30 Jul 2013 16:10:46 -0000 X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RDNS_NONE autolearn=ham version=3.3.1 Received: from Unknown (HELO mms1.broadcom.com) (216.31.210.17) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Jul 2013 16:10:45 +0000 Received: from [10.9.208.57] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Tue, 30 Jul 2013 09:06:39 -0700 X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Tue, 30 Jul 2013 09:10:28 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Tue, 30 Jul 2013 09:10:28 -0700 Received: from [10.177.72.91] (unknown [10.177.72.91]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 69523F2D72 for ; Tue, 30 Jul 2013 09:10:28 -0700 (PDT) Message-ID: <51F7E573.6040001@broadcom.com> Date: Tue, 30 Jul 2013 16:10:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: [PATCH 1/4] Remove deprecated_throw_reason from internal_verror. References: <51F7E51E.3070807@broadcom.com> In-Reply-To: <51F7E51E.3070807@broadcom.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00776.txt.bz2 Removes the use of deprecated_throw_reason from internal_verror. The user will now get an extra "Command aborted" error message in the case where gdb hits an internal error, and the user decides not to quit. This feels like an improvement to me as it /might/ not be obvious that choosing to continue the session will still drop you out of whatever command you were attempting at the time. What do you think? OK to apply? Thanks, Andrew gdb/ChangeLog 2013-07-30 Andrew Burgess * utils.c (internal_verror): Replace use of deprecated_throw_reason with throw_error. diff --git a/gdb/utils.c b/gdb/utils.c index 01212ab..a4ce01c 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -831,7 +831,7 @@ void internal_verror (const char *file, int line, const char *fmt, va_list ap) { internal_vproblem (&internal_error_problem, file, line, fmt, ap); - deprecated_throw_reason (RETURN_ERROR); + throw_error (GENERIC_ERROR, _("Command aborted")); } void