From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1517 invoked by alias); 30 Jul 2013 11:33:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1484 invoked by uid 89); 30 Jul 2013 11:33:50 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Jul 2013 11:33:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6UBXfd0010664 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Jul 2013 07:33:41 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6UB00Bk031755; Tue, 30 Jul 2013 07:00:01 -0400 Message-ID: <51F79CB0.4040809@redhat.com> Date: Tue, 30 Jul 2013 11:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Muhammad Bilal CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH PR gdb/15715] 'set history filename' to by immediately converted to absolute path. References: <97B73E257CC18646B0B5D3DD77DCBDD15DA063@EU-MBX-02.mgc.mentorg.com> <97B73E257CC18646B0B5D3DD77DCBDD15DA08C@EU-MBX-02.mgc.mentorg.com> <51F27050.6060409@redhat.com> <51F607C7.7020108@codesourcery.com> <51F67A1A.8060602@redhat.com> <51F78DB7.8010902@codesourcery.com> <51F790BE.9020306@redhat.com> <51F799A2.1030500@codesourcery.com> In-Reply-To: <51F799A2.1030500@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00760.txt.bz2 On 07/30/2013 11:46 AM, Muhammad Bilal wrote: > 2012-07-30 Muhammad Bilal > > PR gdb/15715 > * top.c: Include "filenames.h". > (set_history_filename): New function. > (init_main): Install it as set hook of the "set history filename" > command. > > /testsuit > 2012-07-30 Muhammad Bilal > > PR gdb/15715 > * gdb.base/setshow.exp: Test that relative paths passed to > 'set history filename' are converted to absolute paths You've lost the period at end of this sentence. It was there in previous versions. I'd like to be sure you learn to pay attention to these details, hence the multiple iterations, but I'd like to avoid having to go through them for all patches. Please be attentive. This is OK with the missing period added (though as penance, I really should have you go through one more round of posting before approving. ;-) ) -- Pedro Alves