Hi Pedro,

On 07/30/2013 03:09 PM, Pedro Alves wrote:
> On 07/30/2013 10:56 AM, Muhammad Bilal wrote:
>> On 07/29/2013 07:20 PM, Pedro Alves wrote:
>>>>>>    static void
>>>>>> +set_history_filename (char *args, int from_tty, struct cmd_list_element *c)
>>>>>> +{
>>>>>> +  /*We include the current directory so that if the user changes
>>>>>> +    directories the file written will be the same as the one
>>>>>> +    that was read.  */
>>>> Formatting still not right.  Add a space after '/*', and then reindent.
>>>> Also, there's trailing whitespace in the first two lines that should not
>>>> The correct format is:
>>>>
>>>>      /* We include the current directory so that if the user changes
>>>>         directories the file written will be the same as the one that
>>>>         was read.  */
> ...
>
>> 2013-07-30  Muhammad Bilal  <mbilal@codesorcery.com>
>>
>>           PR gdb/15715
>>           * top.c: include "filenames.h"
> My initial suggestion was:
>
>            * top.c: Include "filenames.h".
>
> That is, uppercase "include", and finish sentence with period.
> Please fix this.
>
>>   static void
>> +set_history_filename (char *args, int from_tty, struct cmd_list_element *c)
>> +{
>> +  /* We include the current directory so that if the user changes
>> +     directories the file written will be the same as the one
>> +     that was read. */
> The trailing whitespace in first two comment lines is still there.  And
> this lost the double space after period; please add it back.  Or just
> copy the right formatting I pasted in the previous email...
>

2012-07-30  Muhammad Bilal  <mbilal@codesorcery.com>

         PR gdb/15715
         * top.c: Include "filenames.h".
         (set_history_filename): New function.
         (init_main): Install it as set hook of the "set history filename"
         command.

/testsuit
2012-07-30  Muhammad Bilal  <mbilal@codesourcery.com>

         PR gdb/15715
         * gdb.base/setshow.exp: Test that relative paths passed to
         'set history filename' are converted to absolute paths

Please find new one.

I think in ChangeLog, there should be only you name, not mine :)


Thanks,
-Bilal