From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8335 invoked by alias); 30 Jul 2013 10:09:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8313 invoked by uid 89); 30 Jul 2013 10:09:15 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Jul 2013 10:09:14 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6UA94nP023648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Jul 2013 06:09:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6UA92A3011893; Tue, 30 Jul 2013 06:09:03 -0400 Message-ID: <51F790BE.9020306@redhat.com> Date: Tue, 30 Jul 2013 10:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Muhammad Bilal CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH PR gdb/15715] 'set history filename' to by immediately converted to absolute path. References: <97B73E257CC18646B0B5D3DD77DCBDD15DA063@EU-MBX-02.mgc.mentorg.com> <97B73E257CC18646B0B5D3DD77DCBDD15DA08C@EU-MBX-02.mgc.mentorg.com> <51F27050.6060409@redhat.com> <51F607C7.7020108@codesourcery.com> <51F67A1A.8060602@redhat.com> <51F78DB7.8010902@codesourcery.com> In-Reply-To: <51F78DB7.8010902@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00755.txt.bz2 On 07/30/2013 10:56 AM, Muhammad Bilal wrote: > On 07/29/2013 07:20 PM, Pedro Alves wrote: >>> >> static void >>> >> +set_history_filename (char *args, int from_tty, struct cmd_list_element *c) >>> >> +{ >>> >> + /*We include the current directory so that if the user changes >>> >> + directories the file written will be the same as the one >>> >> + that was read. */ >> > Formatting still not right. Add a space after '/*', and then reindent. >> > Also, there's trailing whitespace in the first two lines that should not >> > The correct format is: >> > >> > /* We include the current directory so that if the user changes >> > directories the file written will be the same as the one that >> > was read. */ ... > 2013-07-30 Muhammad Bilal > > PR gdb/15715 > * top.c: include "filenames.h" My initial suggestion was: * top.c: Include "filenames.h". That is, uppercase "include", and finish sentence with period. Please fix this. > static void > +set_history_filename (char *args, int from_tty, struct cmd_list_element *c) > +{ > + /* We include the current directory so that if the user changes > + directories the file written will be the same as the one > + that was read. */ The trailing whitespace in first two comment lines is still there. And this lost the double space after period; please add it back. Or just copy the right formatting I pasted in the previous email... -- Pedro Alves