From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9603 invoked by alias); 30 Jul 2013 00:36:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9594 invoked by uid 89); 30 Jul 2013 00:36:42 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Jul 2013 00:36:41 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1V3xvV-00069N-1C from Yao_Qi@mentor.com ; Mon, 29 Jul 2013 17:36:33 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 29 Jul 2013 17:36:32 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Mon, 29 Jul 2013 17:36:32 -0700 Message-ID: <51F70A63.5090909@codesourcery.com> Date: Tue, 30 Jul 2013 00:36:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH 7/8] fix py-finish-breakpoint.exp with always-async References: <1375116324-32092-1-git-send-email-tromey@redhat.com> <1375116324-32092-8-git-send-email-tromey@redhat.com> In-Reply-To: <1375116324-32092-8-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-07/txt/msg00751.txt.bz2 On 07/30/2013 12:45 AM, Tom Tromey wrote: > However, the code did not follow this comment -- it didn't check to > see if the command started the target. > > This patch fixes the problem by noting whether the target was > executing in sync_execution mode before running the command, and then > augmenting the condition to test this as well. The rationale looks right to me. > > Built and regtested on x86-64 Fedora 18. > > * top.c (execute_command): Only dispatch events if command > started target. I opened PR 14135 for an internal error we saw in gdb.python/py-finish-breakpoint.exp when async is on. If it is the error this patch is to fix, please mention this patch fixes PR 14135 in ChangeLog. http://sourceware.org/bugzilla/show_bug.cgi?id=14135 I also posted a patch for this PR, but it doesn't apply to current trunk. -- Yao (齐尧)