From: Pedro Alves <palves@redhat.com>
To: Raunaq 12 <raunaq12@in.ibm.com>
Cc: gdb-patches@sourceware.org, tromey@redhat.com,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH 2/5] powerpc64-aix processing xlC generated line table
Date: Mon, 29 Jul 2013 16:58:00 -0000 [thread overview]
Message-ID: <51F69F1E.40808@redhat.com> (raw)
In-Reply-To: <OF2681EF63.7B9300E1-ON65257BB7.002254BD-65257BB7.00225FAB@in.ibm.com>
On 07/29/2013 07:15 AM, Raunaq 12 wrote:
> + /* xlc compiled binaries have one less entry in the line table.
> + So the function entry lines marked as line number equal to 0
> + will be retained in the line table with line numbers equal
> + to its succeeding line table entry. */
> +
> + lineTb = lv;
> +
> + for (jj = 0; jj < lineTb->nitems; jj++)
> + {
> + if (lineTb->item[jj].line == 0 && (lineTb->item[jj].pc
> + != lineTb->item[jj + 1].pc))
> + lineTb->item[jj].line = lineTb->item[jj + 1].line;
> + }
> +
...
>
> + /* xlc compiled binaries have one less entry in the line table.
> + So the function entry lines marked as line number equal to 0
> + will be retained in the line table with line numbers equal
> + to its succeeding line table entry. */
> +
> + lineTb = lv;
> +
> + for (jj = 0; jj < lineTb->nitems; jj++)
> + {
> + if (lineTb->item[jj].line == 0 && (lineTb->item[jj].pc
> + != lineTb->item[jj + 1].pc))
> + lineTb->item[jj].line = lineTb->item[jj + 1].line;
> + }
Seems to me this duplicate code could/should be factored out to a helper
function.
--
Pedro Alves
next prev parent reply other threads:[~2013-07-29 16:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 6:15 Raunaq 12
2013-07-29 16:58 ` Pedro Alves [this message]
2013-07-31 9:57 ` Raunaq 12
[not found] ` <OF668B9A7A.5414653D-ON65257BB9.00351B5A-65257BB9.003675D7@LocalDomain>
2013-07-31 10:03 ` Raunaq 12
[not found] <OF1EDEDB55.9DF54135-ON65257BBA.003B42B8-65257BBA.003D0F4D@LocalDomain>
2013-08-07 11:37 ` Raunaq 12
2013-08-07 15:23 ` Ulrich Weigand
2013-08-08 12:04 ` Raunaq 12
2013-08-08 22:01 ` Ulrich Weigand
2013-08-12 7:50 ` Raunaq 12
2013-08-26 15:30 ` Ulrich Weigand
-- strict thread matches above, loose matches on Subject: below --
2013-08-01 11:07 Raunaq 12
2013-07-24 12:37 Raunaq 12
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F69F1E.40808@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=raunaq12@in.ibm.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox