From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19757 invoked by alias); 29 Jul 2013 14:14:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19730 invoked by uid 89); 29 Jul 2013 14:14:04 -0000 X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_20,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 29 Jul 2013 14:14:04 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6TEDn9M012737 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 29 Jul 2013 10:13:50 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6TEDlHA009670; Mon, 29 Jul 2013 10:13:48 -0400 Message-ID: <51F6789B.3090404@redhat.com> Date: Mon, 29 Jul 2013 14:14:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Anton Blanchard CC: Luis Machado , gdb-patches@sourceware.org Subject: Re: [PATCH] Improve performance of large restore commands References: <20130725220858.58184193@kryten> <51F16780.70408@redhat.com> <20130729154457.0e6e6bd7@kryten> In-Reply-To: <20130729154457.0e6e6bd7@kryten> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00702.txt.bz2 On 07/29/2013 06:44 AM, Anton Blanchard wrote: > 2013-07-29 Anton Blanchard > > * target.c (memory_xfer_partial): Cap write to 4K Period at end of sentence. Might as well write KB :-). > > Index: b/gdb/target.c > =================================================================== > --- a/gdb/target.c > +++ b/gdb/target.c > @@ -1669,6 +1669,13 @@ memory_xfer_partial (struct target_ops * > void *buf; > struct cleanup *old_chain; > > + /* A large write request is likely to be partially satisfied > + by memory_xfer_partial_1. We will continually malloc > + and free a copy of the entire write request for breakpoint > + shadow handling even though we only end up writing a small > + subset of it. Cap writes to 4K to mitigate this. */ Double space after all periods, not just the last. > + len = min(4096, len); Space before parens: len = min (4096, len); Otherwise OK. Thanks, -- Pedro Alves