From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10543 invoked by alias); 26 Jul 2013 15:22:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10529 invoked by uid 89); 26 Jul 2013 15:22:52 -0000 X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_20,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 26 Jul 2013 15:22:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6QFMg2W020017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Jul 2013 11:22:43 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6QFMeav012758; Fri, 26 Jul 2013 11:22:41 -0400 Message-ID: <51F29440.3030808@redhat.com> Date: Fri, 26 Jul 2013 15:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tristan Gingold CC: "gdb-patches@sourceware.org ml" , Joel Brobecker Subject: Re: [RFA] Windows x64 SEH unwinder (v2) References: <1357728781-15073-1-git-send-email-brobecker@adacore.com> <1357728781-15073-3-git-send-email-brobecker@adacore.com> <50ED9221.1050504@redhat.com> <9E84DF2D-7AF8-4AA1-A5DF-171EF189A6E7@adacore.com> <50EDA48E.2030406@redhat.com> <66611BA9-4536-42B2-A65C-4EA5DA219E22@adacore.com> <50EEEB3C.9050202@redhat.com> <5BE11EDB-7832-4489-8CB1-6382F5D1D34E@adacore.com> In-Reply-To: <5BE11EDB-7832-4489-8CB1-6382F5D1D34E@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00640.txt.bz2 On 07/08/2013 11:55 AM, Tristan Gingold wrote: > Hello, > > this is the second version of the patch we submitted in January. > I have rewritten amd64_windows_frame_decode_epilogue according to the > very serious review and comments from Pedro. Thanks! (That was here, for reference: http://sourceware.org/ml/gdb-patches/2013-01/msg00165.html I had to go back and read it again, I had already swapped out all my SEH knowledge :-) ) What's the plan for debugging binaries with dwarf instead of SEH? That'd be binaries built with gcc 4.6, IIUC. There was the fallback idea of providing a knob to disable the unwinder. Is that no longer necessary? Did you guys manage to confirm what happens with those binaries? Or will we take the wait until someone complains the missing support approach? If the latter, than I think NEWS should mention we no longer support such binaries. Now that I mention that, I notice the NEWS hunk is mentioned in the ChangeLog, but it's actually missing from the patch. :-) Otherwise I have no further comments. It looks good to me. -- Pedro Alves