Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: don't call add_target for thread_db_ops
Date: Thu, 25 Jul 2013 14:39:00 -0000	[thread overview]
Message-ID: <51F13898.2050700@redhat.com> (raw)
In-Reply-To: <87ehamwwtq.fsf@fleche.redhat.com>

On 07/25/2013 03:14 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
>>> * linux-thread-db.c (init_thread_db_ops): Call
>>> complete_target_initialization.
>>> (_initialize_thread_db): Don't call add_target.
>>> * target.c (complete_target_initialization): New function.
>>> (add_target_with_completer): Call it.
>>> * target.h (complete_target_initialization): Declare.
> 
> Pedro> This is OK.
> 
> Thanks.  I'm checking it in now.

Thanks.  Do you plan on doing the same to the remaining
thread_stratum targets?  If not, I'll do it at some point.
I'd prefer not leaving the incomplete transition in
place; it's bound to confuse someone later on.  I wouldn't
worry much if an affected target goes untested.

-- 
Pedro Alves


  reply	other threads:[~2013-07-25 14:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 16:37 Tom Tromey
2013-07-03  8:46 ` Pedro Alves
2013-07-25 14:14   ` Tom Tromey
2013-07-25 14:39     ` Pedro Alves [this message]
2013-07-25 16:31       ` Tom Tromey
2013-07-25 16:53         ` Pedro Alves
2013-07-25 18:25           ` Tom Tromey
2013-07-26 15:23             ` Ulrich Weigand
2013-08-05 16:52             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F13898.2050700@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox