Re: [PATCH] Revised display-linkage-name

Tom Tromey
2013-07-29T17:48:52Z

>>>>> "Michael" == Michael Eager <eager@eagerm.com> writes:

Tom> FWIW there isn't much need to add new annotations. Annotations are
Tom> officially deprecated. It's fine by me if you want to leave this in for
Tom> some reason though.

Michael> I added the annotations at your request (4/19/13):

Tom>> I think for MI it is better to make this a real field.
Tom>> Also I wonder whether this should be emitted unconditionally if
Tom>> mi-like. Say:

Michael> Perhaps I misunderstood what you meant by "make this a real field".

Yeah, I'm sorry I wasn't clearer.

"annotations" refers to annotate.[ch] and the corresponding command-line
option. This is an old way to communicate gdb state changes to a GUI,
mainly Emacs.

By "a real field" I meant using ui_out_*.

Michael> + ui_out_text (uiout, linkname);

Tom> This is emitting the linkage name using ui_out_text. That is wrong for
Tom> MI.

It maybe wasn't clear but I was referring to the quoted line above when
I said this.

Michael> What should it be? ui_out_field_string()? Something else?

Yes, ui_out_field_string.

Tom