Re: [PATCH] native mingw32 gdb, eol format

Eli Zaretskii
2013-07-16T02:50:08Z

> From: Yao Qi <yao@codesourcery.com>
> Date: Tue, 16 Jul 2013 09:06:07 +0800
>
> This patch, which was written by Pedro, is to force stdout/stderr to
> binary mode prevents that expansion. This patch gets much
> improvement on the test result of mingw native gdb. Is it OK?

No, it's not. A MinGW GDB is a native Windows program, and should
behave like one. Windows programs generally don't expect text coming
through pipes to have Unix EOL format. Also, it is terribly confusing
to have GDB behave differently with its standard handles redirected to
a pipe as opposed to disk files or the console device.

This is a problem with the test suite, so please fix it in the test
suite. If you _must_ make the change in GDB, please introduce some
specialized option to do that. But changing the default behavior like
that is IMO a no-starter.