From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20894 invoked by alias); 18 Jul 2013 07:57:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20883 invoked by uid 89); 18 Jul 2013 07:57:34 -0000 X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_20,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RDNS_NONE autolearn=ham version=3.3.1 Received: from Unknown (HELO mms1.broadcom.com) (216.31.210.17) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Jul 2013 07:57:33 +0000 Received: from [10.9.208.57] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Thu, 18 Jul 2013 00:53:27 -0700 X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Thu, 18 Jul 2013 00:55:30 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.1.438.0; Thu, 18 Jul 2013 00:55:30 -0700 Received: from [10.177.73.66] (unknown [10.177.73.66]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 13ACFF2D73; Thu, 18 Jul 2013 00:55:29 -0700 (PDT) Message-ID: <51E79F70.1030902@broadcom.com> Date: Thu, 18 Jul 2013 07:57:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org cc: "Eli Zaretskii" Subject: Re: [PATCH] [1/2] Add new 'z' format for print command References: <51DAF728.4040309@broadcom.com> <878v1egw5r.fsf@fleche.redhat.com> <51DECD47.60207@broadcom.com> In-Reply-To: <51DECD47.60207@broadcom.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00441.txt.bz2 On 11/07/2013 4:20 PM, Andrew Burgess wrote: > On 10/07/2013 6:30 PM, Tom Tromey wrote: >>>>>>> "Andrew" == Andrew Burgess writes: >> >> Andrew> Pedro pointed out that I could do better, so, this patch >> Andrew> introduces a new 'z' format within the core value printing >> Andrew> code that displays scalars using zero padded hexadecimal. >> Andrew> I've mentioned this in the docs and added a test for the >> Andrew> new format. >> >> Andrew> In patch [2/2] I'll change the MI code to make use of this >> Andrew> new 'z' formatter. >> >> Andrew> OK to apply? >> >> It looks good to me. However, it needs a doc review, and also, I think, >> a NEWS entry. Ping. >> Plus, I think we should wait a little bit in case anyone has an issue >> with the choice of 'z'. As nobody has objected yet I'm going to assume that the use of 'z' is ok.... Thanks, Andrew