Re: [ping 2] [RFA][PATCH v4 0/5] Add TDB regset support

Andreas Arnez
2013-07-15T15:34:31Z

Luis Machado <lgustavo@codesourcery.com> writes:

> I didn't go through your last update of the patch, but FTR i still
> think we should make the core file sections static and store them in
> some form of array instead of hardcoding their contents in numerous
> function calls.

In the PowerPC case the patch includes four call-back invocations, all
contained in a 20-line iterator function. I'd hardly call that
"numerous function calls". And I consider it an improvement over the
original code, which had six hard-coded static array initializers with
various copy-/pasted lines, plus the logic for selecting the correct
array. The improvement is even more drastic for S/390. Don't you
agree? Or do you see even more potential for improvement?