From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 553 invoked by alias); 12 Jul 2013 21:17:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 528 invoked by uid 89); 12 Jul 2013 21:17:32 -0000 X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.1 Received: from Unknown (HELO homiemail-a91.g.dreamhost.com) (208.113.200.5) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 12 Jul 2013 21:17:31 +0000 Received: from homiemail-a91.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a91.g.dreamhost.com (Postfix) with ESMTP id 99716AE07F; Fri, 12 Jul 2013 14:17:03 -0700 (PDT) Received: from redwood.eagercon.com (c-50-148-128-197.hsd1.ca.comcast.net [50.148.128.197]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a91.g.dreamhost.com (Postfix) with ESMTPSA id 6E86EAE07E; Fri, 12 Jul 2013 14:17:03 -0700 (PDT) Message-ID: <51E07263.6080605@eagerm.com> Date: Fri, 12 Jul 2013 21:17:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Keith Seitz CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Revised display-linkage-name References: <519D086A.50105@eagerm.com> <51BF47DB.6070709@eagerm.com> <51DD891D.7090009@eagerm.com> <51DF3F97.90805@redhat.com> In-Reply-To: <51DF3F97.90805@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00336.txt.bz2 On 07/11/13 16:28, Keith Seitz wrote: > On 07/10/2013 09:17 AM, Michael Eager wrote: >> Can someone review and approve this patch? > > Tom's been a little busy of late, so I thought I would try to help out here a little. You'll be one > step closer to approval! > > Your patches no longer apply cleanly to HEAD, so I fixed them up to play with them. I'll be > commenting on this version. > ... > Keith Thanks. I'll look at your comments and submit an update. I'll eliminate the whitespace changes; I find them annoying as well. I'll allow passing a NULL for the linkname where the result is not used. I'm not sure how the default got set to "on"; that was not intentional, and yes, it causes a lot of noise regressions. "Prepend" appears to be listed in some dictionaries as a synonym for "prefix," but it may sound like jargon; I'll change it. I'll look at the suggestions about the test suite. I've reasonable experience with tcl/expect, but tcl always seems to turn into a tar pit. If you have a different term for "linkage name" I'd be happy to hear it. The only use of this that I was able to find is in the DWARF Standard. Or I can add a definition to the docs to clarify. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077