From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10185 invoked by alias); 10 Jul 2013 16:51:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10175 invoked by uid 89); 10 Jul 2013 16:51:25 -0000 X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from caibbdcaaaaf.dreamhost.com (HELO homiemail-a68.g.dreamhost.com) (208.113.200.5) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 10 Jul 2013 16:51:24 +0000 Received: from homiemail-a68.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a68.g.dreamhost.com (Postfix) with ESMTP id EE2B3400F6B1F; Wed, 10 Jul 2013 09:51:22 -0700 (PDT) Received: from redwood.eagercon.com (c-50-148-128-197.hsd1.ca.comcast.net [50.148.128.197]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a68.g.dreamhost.com (Postfix) with ESMTPSA id C1BC5400F6B1D; Wed, 10 Jul 2013 09:51:22 -0700 (PDT) Message-ID: <51DD910A.9040501@eagerm.com> Date: Wed, 10 Jul 2013 16:51:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: Build regression on CentOS-5 [Re: [PATCH 3/3] add -Wold-style-definition] References: <1371494572-26594-1-git-send-email-tromey@redhat.com> <1371494572-26594-4-git-send-email-tromey@redhat.com> <20130702080754.GA24111@host2.jankratochvil.net> <87hagcela1.fsf@fleche.redhat.com> <87a9m4el8y.fsf@fleche.redhat.com> In-Reply-To: <87a9m4el8y.fsf@fleche.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00278.txt.bz2 On 07/02/13 13:54, Tom Tromey wrote: > Tom> As much as I dislike working around old tools, how about the appended? > > Grr, wrong version. > > Tom > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index aca5dbf..7f6e7b6 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -165,6 +165,8 @@ GDB_WERROR_CFLAGS = $(WERROR_CFLAGS) > > GDB_WARN_CFLAGS_NO_FORMAT = `echo " $(GDB_WARN_CFLAGS) " \ > | sed "s/ -Wformat-nonliteral / -Wno-format-nonliteral /g"` > +GDB_WARN_CFLAGS_NO_DEFS = `echo " $(GDB_WARN_CFLAGS) " \ > + | sed "s/ -Wold-style-definition / -Wno-old-style-definition /g"` > > RDYNAMIC = @RDYNAMIC@ > > @@ -1580,6 +1582,17 @@ printcmd.o: $(srcdir)/printcmd.c > $(COMPILE.post) $(srcdir)/printcmd.c > $(POSTCOMPILE) > > +# ada-exp.c can appear in srcdir, for releases; or in ., for > +# development builds. > +ADA_EXP_C = `if test -f ada-exp.c; then echo ada-exp.c; else echo $(srcdir)/ada-exp.c; fi` > + > +# Some versions of flex give output that triggers > +# -Wold-style-definition. > +ada-exp.o: ada-exp.c > + $(COMPILE.pre) $(INTERNAL_CFLAGS) $(GDB_WARN_CFLAGS_NO_DEFS) \ > + $(COMPILE.post) $(ADA_EXP_C) > + $(POSTCOMPILE) > + > # Message files. Based on code in gcc/Makefile.in. > > # Rules for generating translated message descriptions. Disabled by Are you going to check in the fix for this regression? -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077