From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 554 invoked by alias); 10 Jul 2013 16:17:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 537 invoked by uid 89); 10 Jul 2013 16:17:36 -0000 X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE autolearn=no version=3.3.1 Received: from caibbdcaaaaf.dreamhost.com (HELO homiemail-a57.g.dreamhost.com) (208.113.200.5) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 10 Jul 2013 16:17:35 +0000 Received: from homiemail-a57.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a57.g.dreamhost.com (Postfix) with ESMTP id E4A7420807A for ; Wed, 10 Jul 2013 09:17:33 -0700 (PDT) Received: from redwood.eagercon.com (c-50-148-128-197.hsd1.ca.comcast.net [50.148.128.197]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a57.g.dreamhost.com (Postfix) with ESMTPSA id D33FC208056 for ; Wed, 10 Jul 2013 09:17:33 -0700 (PDT) Message-ID: <51DD891D.7090009@eagerm.com> Date: Wed, 10 Jul 2013 16:17:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] Revised display-linkage-name References: <519D086A.50105@eagerm.com> <51BF47DB.6070709@eagerm.com> In-Reply-To: <51BF47DB.6070709@eagerm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00276.txt.bz2 Ping! Can someone review and approve this patch? On 06/17/13 10:31, Michael Eager wrote: > Ping! > > On 05/22/2013 11:03 AM, Michael Eager wrote: >> Attached is a revised patch to display the linkage name (the linker symbol) >> along with the function name when setting, listing, or hitting a breakpoint. >> This is a revision of http://sourceware.org/ml/gdb-patches/2013-03/msg00806.html. >> (BTW, the gdb-patches mailing list archive doesn't show the original email from >> 3/18/13, quoted in the referenced message.) >> >> Changes: >> Add NEWS and docs. >> Add linkage name to "info break" listing. >> Add MI annotations. >> Add command to set/show display length limit, remove define. >> Add test case. >> >> There is a minor inconsistency where the linkage name is displayed. >> When setting/hitting a breakpoint, the linkage name is displayed >> within brackets following the source name, before the arguments. In >> the "info breakpoint" command, the linkage name is displayed in brackets >> after the arguments. This is because SYMBOL_PRINT_NAME(sym) returns a >> complete function signature, not just the function name. >> >> The test case was added to gdb.cp for convenience, since it uses >> the C++ compiler. The patch is not dependent on C++. >> >> Tom -- can you verify that the MI support is correct? I don't have >> any way to test this. >> >> >> gdb/ >> 2013-05-23 Michael Eager >> >> * NEWS: Announcement. >> * ada-lang.c: Update calls to find_frame_funname. >> * disasm.c: Likewise. >> * python/py-frame.c: Likewise. >> * annotate.c (annotate_linkage_name): New. >> * annotate.h (annotate_linkage_name): Declare. >> * breakpoint.c (print_breakpoint_location): Print linkage name. >> * defs.h (build_address_symbolic): Add linkname arg. >> * printcmd.c (print_address_symbolic): Print linkage name. >> (build_address_symbolic): Return linkage name. >> * stack.c (find_frame_funname): Return linkage name. >> (print_frame): Print linkage name. >> * stack.h (find_frame_funname): Update declaration. >> * top.c (display_linkage_name, display_linkage_name_len): New. >> (show_display_linkage_name, show_display_linkage_name_len): New cmds. >> * top.h (display_linkage_name, display_linkage_name_len): Declare. >> >> gdb/doc >> 2013-05-23 Michael Eager >> >> * gdb.texinfo: Add description. >> >> gdb/testsuite >> 2013-05-23 Michael Eager >> >> * gdb.cp/display-linkage-name.exp: New. >> * gdb.cp/display-linkage-name.cc: New. >> > > -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077