From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12383 invoked by alias); 10 Jul 2013 06:21:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12371 invoked by uid 89); 10 Jul 2013 06:21:55 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_BM autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 10 Jul 2013 06:21:54 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Uwnmh-0000tA-EG from Yao_Qi@mentor.com ; Tue, 09 Jul 2013 23:21:51 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 9 Jul 2013 23:21:50 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Tue, 9 Jul 2013 23:21:50 -0700 Message-ID: <51DCFD6D.4090502@codesourcery.com> Date: Wed, 10 Jul 2013 06:21:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH] Fix up msymbol type of dll trampoline to mst_solib_trampoline References: <1372043502-4618-1-git-send-email-yao@codesourcery.com> <874ncjmgkl.fsf@fleche.redhat.com> <51CD0054.9040401@codesourcery.com> <87ehbmkzqr.fsf@fleche.redhat.com> <51D36FB3.4070006@codesourcery.com> In-Reply-To: <51D36FB3.4070006@codesourcery.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-07/txt/msg00259.txt.bz2 On 07/03/2013 08:26 AM, Yao Qi wrote: > In the updated patch, I use hash table when looking for up minsyms, but > in a little different way. After currently constructing minsyms are > installed to OBJFILE, there is a hash table built, we can use that one, > instead of maintaining a separate one. That is, after the hash table > of minsyms of OBJFILE is built up, we can iterate all minsyms, if > symbol is _imp_x, look up x in the hash table. If found, modify the > found's type. > > Regression tested on i686-pc-mingw32. The following fail is fixed. > > FAIL: gdb.base/solib-symbol.exp: foo in libmd Ping. http://sourceware.org/ml/gdb-patches/2013-07/msg00100.html -- Yao (齐尧)