From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13226 invoked by alias); 9 Jul 2013 16:18:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13211 invoked by uid 89); 9 Jul 2013 16:18:51 -0000 X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-pa0-f48.google.com (HELO mail-pa0-f48.google.com) (209.85.220.48) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 09 Jul 2013 16:18:50 +0000 Received: by mail-pa0-f48.google.com with SMTP id kp12so5696090pab.21 for ; Tue, 09 Jul 2013 09:18:49 -0700 (PDT) X-Received: by 10.68.247.226 with SMTP id yh2mr26848096pbc.164.1373386729058; Tue, 09 Jul 2013 09:18:49 -0700 (PDT) Received: from [192.168.1.5] (114-25-181-13.dynamic.hinet.net. [114.25.181.13]) by mx.google.com with ESMTPSA id x8sm29009231pbb.39.2013.07.09.09.18.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 09 Jul 2013 09:18:48 -0700 (PDT) Message-ID: <51DC37DD.9030709@gmail.com> Date: Tue, 09 Jul 2013 16:18:00 -0000 From: Wei-cheng Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Joseph S. Myers" CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/5] Code for nds32 target References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00249.txt.bz2 On 7/9/2013 7:58 AM, Joseph S. Myers wrote: > I advise reviewing this whole comment, and the Linux port in general, for > whether it is still current. > > I don't see the kernel port as of Linux 3.10, and Linux kernel policy as I > understand it is that new architectures are expected to use the generic > syscall interface, which only has rt_sigreturn. So, references to the old > non-realtime sigreturn are suspect for new architectures. Similarly, > references to glibc 2.1.2 are suspect for an architecture with no glibc > port as of 2.18. (If the Linux ABI isn't fully confirmed with the > upstream Linux kernel community, you might want to submit the non-Linux > parts of the GDB port and come back to the Linux parts later.) Hi Joseph, This part is based on our outdated glibc 2.5 porting, and we are still working on glibc 2.18, so I agree we withdraw this part in revised patch, and come back when our glibc 2.18 porting is ready. Thanks for pointing out this and the suggestions. I will review the patch thoroughly again. Wei-cheng