From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25658 invoked by alias); 9 Jul 2013 14:16:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25639 invoked by uid 89); 9 Jul 2013 14:16:11 -0000 X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 09 Jul 2013 14:16:10 +0000 Received: from [10.9.208.57] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Tue, 09 Jul 2013 07:10:05 -0700 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Tue, 9 Jul 2013 07:16:00 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.1.438.0; Tue, 9 Jul 2013 07:16:00 -0700 Received: from [10.177.73.66] (unknown [10.177.73.66]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 0165BF2DA8; Tue, 9 Jul 2013 07:15:54 -0700 (PDT) Message-ID: <51DC1B1A.5090203@broadcom.com> Date: Tue, 09 Jul 2013 14:16:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Jan Kratochvil" , "Pedro Alves" cc: gdb-patches@sourceware.org Subject: Re: Regression for implptr.exp and pieces.exp [Re: [COMMIT PATCH] value_bits_valid: Fix latent bug.] References: <20130704160927.11801.10290.stgit@brno.lan> <51D6DB44.1000609@broadcom.com> <51D6E0EB.3040006@redhat.com> <51D6E441.4040709@broadcom.com> <51D70EBB.4050505@redhat.com> <51DA92D9.8050408@broadcom.com> <20130709095442.GA20006@host2.jankratochvil.net> In-Reply-To: <20130709095442.GA20006@host2.jankratochvil.net> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00246.txt.bz2 On 09/07/2013 10:54 AM, Jan Kratochvil wrote: > On Mon, 08 Jul 2013 12:22:17 +0200, Andrew Burgess wrote: >> On 05/07/2013 7:21 PM, Pedro Alves wrote: >>> On 07/05/2013 04:20 PM, Andrew Burgess wrote: >>> >>>> 2013-07-05 Andrew Burgess >>>> >>>> * value.c (value_bits_valid): If the value is not lval_computed >>>> or has no check validity handler then the answer is the >>>> optimized_out flag, otherwise defer to the handler. >>> >>> OK. >> >> Committed. > > On any platform I test for 32-bit targets (either on i386 native host or on > x86_64 host with -m32 target cflags) I get: > > 9f5e30f7cf73a3256fbb9a265c897aa3f2c91439 is the first bad commit > commit 9f5e30f7cf73a3256fbb9a265c897aa3f2c91439 > Author: aburgess > Date: Mon Jul 8 10:21:33 2013 +0000 > > Fix bug in value_bits_valid. > > http://sourceware.org/ml/gdb-patches/2013-07/msg00174.html > > * value.c (value_bits_valid): If the value is not lval_computed > or has no check validity handler then the answer is the > optimized_out flag, otherwise defer to the handler. > > Running gdb/testsuite/gdb.dwarf2/implptr.exp ... > -PASS: gdb.dwarf2/implptr.exp: print j in implptr:bar > +FAIL: gdb.dwarf2/implptr.exp: print j in implptr:bar > -PASS: gdb.dwarf2/implptr.exp: print p[0].x in implptr:foo > +FAIL: gdb.dwarf2/implptr.exp: print p[0].x in implptr:foo > > Running gdb/testsuite/gdb.dwarf2/pieces.exp ... > -PASS: gdb.dwarf2/pieces.exp: print a.i in pieces:f3 > -PASS: gdb.dwarf2/pieces.exp: print a.j in pieces:f3 > -PASS: gdb.dwarf2/pieces.exp: set a.i in pieces:f3 > -PASS: gdb.dwarf2/pieces.exp: print new a.i in pieces:f3 > +FAIL: gdb.dwarf2/pieces.exp: print a.i in pieces:f3 > +FAIL: gdb.dwarf2/pieces.exp: print a.j in pieces:f3 > +FAIL: gdb.dwarf2/pieces.exp: set a.i in pieces:f3 > +FAIL: gdb.dwarf2/pieces.exp: print new a.i in pieces:f3 > I've committed a patch to revert all the changes done by Pedro and myself to value_bits_valid, this is what Pedro was going to do anyway here: http://sourceware.org/ml/gdb-patches/2013-07/msg00200.html before I jumped in. Looking again at this function I don't believe either the original (now current again) version, or any of the versions we've tried are actually correct, but fixing this properly is going to be slightly more involved, and I don't have time to put the patch together today. Sorry for the inconvenience. Andrew.