From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31914 invoked by alias); 6 Jul 2013 02:41:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31904 invoked by uid 89); 6 Jul 2013 02:41:17 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 06 Jul 2013 02:40:53 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UvIQc-0002zd-UO from Luis_Gustavo@mentor.com ; Fri, 05 Jul 2013 19:40:50 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 5 Jul 2013 19:40:50 -0700 Received: from [172.30.14.191] ([172.30.14.191]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 5 Jul 2013 19:40:50 -0700 Message-ID: <51D783AE.50906@codesourcery.com> Date: Sat, 06 Jul 2013 02:41:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pedro Alves CC: Tom Tromey , Stan Shebs , GDB Patches , Ulrich Weigand Subject: Re: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64. References: <51D1AD43.3060904@codesourcery.com> <8761wsgb8i.fsf@fleche.redhat.com> <51D3050C.4070309@codesourcery.com> <51D30BB0.3050906@earthlink.net> <87wqp8estz.fsf@fleche.redhat.com> <51D32100.4000901@codesourcery.com> <51D43DBB.5090803@redhat.com> <51D47A05.9020404@codesourcery.com> <51D47AC4.1020208@redhat.com> <51D48763.7020703@codesourcery.com> <51D52E02.4020607@redhat.com> In-Reply-To: <51D52E02.4020607@redhat.com> Content-Type: multipart/mixed; boundary="------------020700000804080008090608" X-Virus-Found: No X-SW-Source: 2013-07/txt/msg00211.txt.bz2 This is a multi-part message in MIME format. --------------020700000804080008090608 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 366 On 07/04/2013 05:10 AM, Pedro Alves wrote: > On 07/03/2013 09:19 PM, Luis Machado wrote: >> On 07/03/2013 04:25 PM, Pedro Alves wrote: > >>> But do you see a problem with checking whether "&intarray is < 32-bit" instead? >>> >> >> Not really. Like so? > > Yep, exactly like that. > > Thanks, > Thanks. Here is what i checked in. I restored the SPU exception. Luis --------------020700000804080008090608 Content-Type: text/x-patch; name="dump_exp.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="dump_exp.diff" Content-length: 1560 2013-07-05 Luis Machado * gdb.base/dump.exp: Remove arch-specific tests and do a generic data address check to set is64bitonly correctly. diff --git a/gdb/testsuite/gdb.base/dump.exp b/gdb/testsuite/gdb.base/dump.exp index ea93b89..eb9be90 100644 --- a/gdb/testsuite/gdb.base/dump.exp +++ b/gdb/testsuite/gdb.base/dump.exp @@ -30,10 +30,6 @@ if [istarget "alpha*-*-*"] then { lappend options "additional_flags=-Wl,-taso" } -if {[istarget "ia64*-*-*"] || [istarget "hppa64-*-*"]} then { - set is64bitonly "yes" -} - if {[istarget "spu*-*-*"]} then { # The internal address format used for the combined Cell/B.E. # debugger requires 64-bit. @@ -56,6 +52,15 @@ gdb_test "dump mem /dev/null 0x10 0x20" "Cannot access memory at address 0x10" \ gdb_load ${binfile} +# Check the address of a variable. If it is bigger than 32-bit, +# assume our target has 64-bit addresses that are not supported by SREC, +# IHEX and TEKHEX. We skip those tests then. +set max_32bit_address "0xffffffff" +set data_address [get_hexadecimal_valueof "&intarray" 0x100000000] +if {${data_address} > ${max_32bit_address}} then { + set is64bitonly "yes" +} + # Clean up any stale output files from previous test runs remote_exec build "rm -f intarr1.bin intarr1b.bin intarr1.ihex intarr1.srec intarr1.tekhex intarr2.bin intarr2b.bin intarr2.ihex intarr2.srec intarr2.tekhex intstr1.bin intstr1b.bin intstr1.ihex intstr1.srec intstr1.tekhex intstr2.bin intstr2b.bin intstr2.ihex intstr2.srec intstr2.tekhex intarr3.srec" --------------020700000804080008090608--