From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16101 invoked by alias); 5 Jul 2013 03:07:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16090 invoked by uid 89); 5 Jul 2013 03:07:23 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 05 Jul 2013 03:07:19 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UuwMf-0000d0-LE from Yao_Qi@mentor.com ; Thu, 04 Jul 2013 20:07:17 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 4 Jul 2013 20:07:17 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Thu, 4 Jul 2013 20:07:16 -0700 Message-ID: <51D63853.1040706@codesourcery.com> Date: Fri, 05 Jul 2013 03:07:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: , Pedro Alves Subject: Re: [PATCH 00/16] clean up remote.c state References: <1371835506-15691-1-git-send-email-tromey@redhat.com> In-Reply-To: <1371835506-15691-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-07/txt/msg00180.txt.bz2 On 06/22/2013 01:24 AM, Tom Tromey wrote: > * I think the client-stop notification code needs some update Yes, the global 'notif_queue' should be moved for each remote state. My pending patches on supported notifications and annexes probably should be updated for per remote target as well, because different remote targets may have different supported notifications and annexes. [PATCH v4 0/5] MI notification on trace started/stopped http://sourceware.org/ml/gdb-patches/2013-04/msg00019.html I am not sure we are still interested in this patch series, as I get no response after a recent ping to Pedro on June. > After this series goes in, I propose that all future remote.c changes > be reviewed to ensure that remote state is in remote_state and not a > new global variable. > I agree. The 'trace started/stopped' patch series were submitted some months ago, IWBN to review them now, and then I'd like to convert the whole async remote notification to a per remote target manner in the next step. It will save a lot of efforts on rewriting patches, re-splitting and rebasing. WDYT? -- Yao (齐尧)