Re: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64.

Luis Machado
2013-07-02T14:45:19Z

On 07/02/2013 11:37 AM, Yao Qi wrote:
> On 07/02/2013 12:24 AM, Luis Machado wrote:
>> +# Since SREC, IHEX and TEKHEX cannot handle 64-bit addresses for
>> +# MIPS64, stop testing if we have a 64-bit MIPS program.
>> +if {[istarget "mips*-*-*"]} then {
>> + send_gdb "show mips abi\n"
>> + gdb_expect {
>> + -re ".*n64.*$gdb_prompt $" {
>> + set is64bitonly "yes"
>> + }
>> + }
>> +}
>> +
>
> Luis,
> this patch looks reasonable to me. Probably, we should move the code to
> the place close to the existing code setting "is64bitonly" too.
>

For MIPS we need to load the binary first to be able to tell if we
really have a N64 ABI or not. That is why this check is a bit later in
the code compared to the other checks.

Does that make sense?

Luis