Re: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64.

Stan Shebs
2013-07-02T17:19:52Z

On 7/2/13 9:51 AM, Luis Machado wrote:
> On 07/02/2013 01:47 PM, Tom Tromey wrote:
>>>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:
>>
>> Luis> Skipping this test for MIPS is not the right thing as some ABI's
>> are
>> Luis> 32-bit and so should be tested against the usual set of SREC,
>> IHEX and
>> Luis> TEKHEX formats.
>>
>> Luis> The attached patch checks for the N64 ABI and sets the internal
>> flag
>> Luis> is64bitonly accordingly, skipping the SREC, IHEX and TEKHEX tests.
>>
>> Should this be made more generic?
>> Say, test for "sizeof(&main) != 4"?
>
> It could be, if we can guarantee oddball architectures don't use
> pointers and addresses of strange sizes, say, an arch that declares
> function pointers of 4 bytes.

You could test both a function address and a data address, and if either
is greater than 4 bytes, the old formats can be excluded from testing.

Stan
stan@codesourcery.com