From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6374 invoked by alias); 3 Jul 2013 10:55:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6345 invoked by uid 89); 3 Jul 2013 10:55:36 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 03 Jul 2013 10:55:35 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UuKii-0004Pb-Qq from Yao_Qi@mentor.com ; Wed, 03 Jul 2013 03:55:32 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 3 Jul 2013 03:55:32 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Wed, 3 Jul 2013 03:55:31 -0700 Message-ID: <51D4030F.6070000@codesourcery.com> Date: Wed, 03 Jul 2013 10:55:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches ml Subject: Re: [PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes References: <51D2E749.9020604@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-07/txt/msg00136.txt.bz2 On 07/03/2013 04:41 PM, Hui Zhu wrote: > @@ -68,7 +68,7 @@ proc mi_continue_dprintf {args} { > mi_run_cmd > set msg "mi 1st dprintf" > gdb_expect { > - -re ".*At foo entry.*arg=1234, g=1234" { > + -re ".*foobarbazqux.*At foo entry.*arg=1234, g=1234" { It is good if we match double quotes before and after foobarbazqux, and get rid of ".*" between "foobarbazqux" and "At foo entry", in order to get the test more restrictive. Something like ".*\\\\\"foobarbazqux\\\\\" At foo entry.*arg=1234, g=1234" I have no other comments then. -- Yao (齐尧)