From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2309 invoked by alias); 3 Jul 2013 08:46:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2298 invoked by uid 89); 3 Jul 2013 08:46:07 -0000 X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 03 Jul 2013 08:46:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r638k5eJ024243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Jul 2013 04:46:05 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r638k3ON031560; Wed, 3 Jul 2013 04:46:04 -0400 Message-ID: <51D3E4CB.3060801@redhat.com> Date: Wed, 03 Jul 2013 08:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: RFC: don't call add_target for thread_db_ops References: <1372783053-14925-1-git-send-email-tromey@redhat.com> In-Reply-To: <1372783053-14925-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00107.txt.bz2 On 07/02/2013 05:37 PM, Tom Tromey wrote: > * linux-thread-db.c (init_thread_db_ops): Call > complete_target_initialization. > (_initialize_thread_db): Don't call add_target. > * target.c (complete_target_initialization): New function. > (add_target_with_completer): Call it. > * target.h (complete_target_initialization): Declare. This is OK. Really all the thread_stratum targets should be likewise adjusted: $ grep "to_stratum.*thread_stratum;" * -l | xargs grep add_target aix-thread.c: add_target (&aix_thread_ops); bsd-uthread.c: add_target (bsd_uthread_target ()); dec-thread.c: add_target (&dec_thread_ops); linux-thread-db.c: add_target (&thread_db_ops); ravenscar-thread.c: add_target (&ravenscar_ops); sol-thread.c: add_target (&sol_thread_ops); -- Pedro Alves